]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
io_uring: fix IO hang in io_wq_put_and_exit from do_exit()
authorMing Lei <ming.lei@redhat.com>
Fri, 1 Sep 2023 13:49:16 +0000 (21:49 +0800)
committerJens Axboe <axboe@kernel.dk>
Fri, 1 Sep 2023 13:54:06 +0000 (07:54 -0600)
commitb484a40dc1f16edb58e5430105a021e1916e6f27
tree83d03fb7a8cacab3b52f3b707def4a7960ff2894
parentbd6fc5da4c51107e1e0cec4a3a07963d1dae2c84
io_uring: fix IO hang in io_wq_put_and_exit from do_exit()

io_wq_put_and_exit() is called from do_exit(), but all FIXED_FILE requests
in io_wq aren't canceled in io_uring_cancel_generic() called from do_exit().
Meantime io_wq IO code path may share resource with normal iopoll code
path.

So if any HIPRI request is submittd via io_wq, this request may not get resouce
for moving on, given iopoll isn't possible in io_wq_put_and_exit().

The issue can be triggered when terminating 't/io_uring -n4 /dev/nullb0'
with default null_blk parameters.

Fix it by always cancelling all requests in io_wq by adding helper of
io_uring_cancel_wq(), and this way is reasonable because io_wq destroying
follows canceling requests immediately.

Closes: https://lore.kernel.org/linux-block/3893581.1691785261@warthog.procyon.org.uk/
Reported-by: David Howells <dhowells@redhat.com>
Cc: Chengming Zhou <zhouchengming@bytedance.com>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Link: https://lore.kernel.org/r/20230901134916.2415386-1-ming.lei@redhat.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
io_uring/io_uring.c