]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
net: kcm: fix memory leak in kcm_sendmsg
authorPavel Skripkin <paskripkin@gmail.com>
Wed, 2 Jun 2021 19:26:40 +0000 (22:26 +0300)
committerDavid S. Miller <davem@davemloft.net>
Thu, 3 Jun 2021 21:13:26 +0000 (14:13 -0700)
commitc47cc304990a2813995b1a92bbc11d0bb9a19ea9
tree434c67f2c3d561623e2de4ab6fdbc7fdb057bc09
parent261ba78cc364ad595cead555a7d2a61471eac165
net: kcm: fix memory leak in kcm_sendmsg

Syzbot reported memory leak in kcm_sendmsg()[1].
The problem was in non-freed frag_list in case of error.

In the while loop:

if (head == skb)
skb_shinfo(head)->frag_list = tskb;
else
skb->next = tskb;

frag_list filled with skbs, but nothing was freeing them.

backtrace:
  [<0000000094c02615>] __alloc_skb+0x5e/0x250 net/core/skbuff.c:198
  [<00000000e5386cbd>] alloc_skb include/linux/skbuff.h:1083 [inline]
  [<00000000e5386cbd>] kcm_sendmsg+0x3b6/0xa50 net/kcm/kcmsock.c:967 [1]
  [<00000000f1613a8a>] sock_sendmsg_nosec net/socket.c:652 [inline]
  [<00000000f1613a8a>] sock_sendmsg+0x4c/0x60 net/socket.c:672

Reported-and-tested-by: syzbot+b039f5699bd82e1fb011@syzkaller.appspotmail.com
Fixes: ab7ac4eb9832 ("kcm: Kernel Connection Multiplexor module")
Cc: stable@vger.kernel.org
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/kcm/kcmsock.c