]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
leds: simatic-ipc-leds-gpio: Make sure we have the GPIO providing driver
authorHenning Schild <henning.schild@siemens.com>
Fri, 7 Oct 2022 15:33:23 +0000 (17:33 +0200)
committerLee Jones <lee@kernel.org>
Mon, 30 Jan 2023 08:03:43 +0000 (08:03 +0000)
commitc64964ebee2a415384385205950ee7a05f78451e
tree46af132a8775cbabac3b15cf047f501d22221f3d
parent8f47707acd0b65a9e797bc7288a9183131d5ce74
leds: simatic-ipc-leds-gpio: Make sure we have the GPIO providing driver

If we register a "leds-gpio" platform device for GPIO pins that do not
exist we get a -EPROBE_DEFER and the probe will be tried again later.
If there is no driver to provide that pin we will poll forever and also
create a lot of log messages.

So check if that GPIO driver is configured, if so it will come up
eventually. If not, we exit our probe function early and do not even
bother registering the "leds-gpio". This method was chosen over "Kconfig
depends" since this way we can add support for more devices and GPIO
backends more easily without "depends":ing on all GPIO backends.

Fixes: a6c80bec3c93 ("leds: simatic-ipc-leds-gpio: Add GPIO version of Siemens driver")
Signed-off-by: Henning Schild <henning.schild@siemens.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Lee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20221007153323.1326-1-henning.schild@siemens.com
drivers/leds/simple/simatic-ipc-leds-gpio.c