]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
serial: mvebu-uart: fix tx lost characters
authorGabriel Matni <gabriel.matni@exfo.com>
Thu, 22 Mar 2018 19:15:12 +0000 (19:15 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 22 Mar 2018 20:27:44 +0000 (21:27 +0100)
commitc685af1108d7c303f0b901413405d68eaeac4477
treeea0d6e8358debb193b8eb233a0f019fe6ff152db
parent7693b331d033ecda61097007330d3e7461ff7f27
serial: mvebu-uart: fix tx lost characters

Fixes missing characters on kernel console at low baud rates (i.e.9600).
The driver should poll TX_RDY or TX_FIFO_EMP instead of TX_EMP to ensure
that the transmitter holding register (THR) is ready to receive a new byte.

TX_EMP tells us when it is possible to send a break sequence via
SND_BRK_SEQ. While this also indicates that both the THR and the TSR are
empty, it does not guarantee that a new byte can be written just yet.

Fixes: 30530791a7a0 ("serial: mvebu-uart: initial support for Armada-3700 serial port")
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Acked-by: Gregory CLEMENT <gregory.clement@bootlin.com>
Signed-off-by: Gabriel Matni <gabriel.matni@exfo.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/mvebu-uart.c