]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
sh_eth: avoid PHY being resumed when interface is not up
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Wed, 15 Mar 2023 07:41:15 +0000 (08:41 +0100)
committerJakub Kicinski <kuba@kernel.org>
Fri, 17 Mar 2023 00:13:55 +0000 (17:13 -0700)
commitc6be7136afb224a01d4cde2983ddebac8da98693
tree3cfe1e17ea400fb2864451c35d481626b37593a9
parent7f5ebf5dae42e710162f1c481ebcf28ab7b741c7
sh_eth: avoid PHY being resumed when interface is not up

SH_ETH doesn't need mdiobus suspend/resume, that's why it sets
'mac_managed_pm'. However, setting it needs to be moved from init to
probe, so mdiobus PM functions will really never be called (e.g. when
the interface is not up yet during suspend/resume).

Fixes: 6a1dbfefdae4 ("net: sh_eth: Fix PHY state warning splat during system resume")
Suggested-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/renesas/sh_eth.c