]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
pty: Fix lock inversion
authorAlan Cox <alan@linux.intel.com>
Tue, 29 May 2012 12:45:01 +0000 (13:45 +0100)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 29 May 2012 17:42:13 +0000 (10:42 -0700)
commitd3ca8b64b97ef4dc54d7bb0b88bbc01a1fca8cb9
tree6205c4d17144485ff6ec3783463b0ed6e84bf831
parenta01ee165a132fadb57659d26246e340d6ac53265
pty: Fix lock inversion

The ptmx_open path takes the tty and devpts locks in the wrong order
because tty_init_dev locks and returns a locked tty.  As far as I can
tell this is actually safe anyway because the tty being returned is new
so nobody can get a reference to lock it at this point.

However we don't even need the devpts lock at this point, it's only held
as a byproduct of the way the locks were pushe down.

Signed-off-by: Alan Cox <alan@linux.intel.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/tty/pty.c