]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
bnx2x: fix checksum validation
authorEric Dumazet <edumazet@google.com>
Tue, 12 Jun 2012 23:50:04 +0000 (23:50 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 13 Jun 2012 22:58:53 +0000 (15:58 -0700)
commitd6cb3e41386f20fb0777d0b59a2def82c65d37f7
treef1a04833d77287468411c68fd780b95976e4bf59
parent954fba0274058d27c7c07b5ea07c41b3b7477894
bnx2x: fix checksum validation

bnx2x driver incorrectly sets ip_summed to CHECKSUM_UNNECESSARY on
encapsulated segments. TCP stack happily accepts frames with bad
checksums, if they are inside a GRE or IPIP encapsulation.

Our understanding is that if no IP or L4 csum validation was done by the
hardware, we should leave ip_summed as is (CHECKSUM_NONE), since
hardware doesn't provide CHECKSUM_COMPLETE support in its cqe.

Then, if IP/L4 checksumming was done by the hardware, set
CHECKSUM_UNNECESSARY if no error was flagged.

Patch based on findings and analysis from Robert Evans

Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Eilon Greenstein <eilong@broadcom.com>
Cc: Yaniv Rosner <yanivr@broadcom.com>
Cc: Merav Sicron <meravs@broadcom.com>
Cc: Tom Herbert <therbert@google.com>
Cc: Robert Evans <evansr@google.com>
Cc: Willem de Bruijn <willemb@google.com>
Acked-by: Eilon Greenstein <eilong@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnx2x/bnx2x.h
drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c