]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
NFC: nci: Add some bounds checking in nci_hci_cmd_received()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 3 Apr 2019 07:12:48 +0000 (10:12 +0300)
committerDavid S. Miller <davem@davemloft.net>
Sat, 6 Apr 2019 22:05:07 +0000 (15:05 -0700)
commitd7ee81ad09f072eab1681877fc71ec05f9c1ae92
treeda9e6eca74c5d82e6b1ce44423284fa312721e78
parent7f46774c6480174eb869a3c15167eafac467a6af
NFC: nci: Add some bounds checking in nci_hci_cmd_received()

This is similar to commit 674d9de02aa7 ("NFC: Fix possible memory
corruption when handling SHDLC I-Frame commands").

I'm not totally sure, but I think that commit description may have
overstated the danger.  I was under the impression that this data came
from the firmware?  If you can't trust your networking firmware, then
you're already in trouble.

Anyway, these days we add bounds checking where ever we can and we call
it kernel hardening.  Better safe than sorry.

Fixes: 11f54f228643 ("NFC: nci: Add HCI over NCI protocol support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/nfc/nci/hci.c