]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
sched/uclamp: Fix initialization of struct uclamp_rq
authorQais Yousef <qais.yousef@arm.com>
Tue, 30 Jun 2020 11:21:22 +0000 (12:21 +0100)
committerPeter Zijlstra <peterz@infradead.org>
Wed, 8 Jul 2020 09:39:01 +0000 (11:39 +0200)
commitd81ae8aac85ca2e307d273f6dc7863a721bf054e
tree30358d803f92a87ecf910ac67f9f947cace500c2
parent85c2ce9104eb93517db2037699471c517e81f9b4
sched/uclamp: Fix initialization of struct uclamp_rq

struct uclamp_rq was zeroed out entirely in assumption that in the first
call to uclamp_rq_inc() they'd be initialized correctly in accordance to
default settings.

But when next patch introduces a static key to skip
uclamp_rq_{inc,dec}() until userspace opts in to use uclamp, schedutil
will fail to perform any frequency changes because the
rq->uclamp[UCLAMP_MAX].value is zeroed at init and stays as such. Which
means all rqs are capped to 0 by default.

Fix it by making sure we do proper initialization at init without
relying on uclamp_rq_inc() doing it later.

Fixes: 69842cba9ace ("sched/uclamp: Add CPU's clamp buckets refcounting")
Signed-off-by: Qais Yousef <qais.yousef@arm.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Valentin Schneider <valentin.schneider@arm.com>
Tested-by: Lukasz Luba <lukasz.luba@arm.com>
Link: https://lkml.kernel.org/r/20200630112123.12076-2-qais.yousef@arm.com
kernel/sched/core.c