]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
bnx2x: Don't release PCI bars on shutdown
authorYuval Mintz <yuvalmin@broadcom.com>
Wed, 15 Jan 2014 10:05:30 +0000 (12:05 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 16 Jan 2014 00:48:34 +0000 (16:48 -0800)
commitd9aee591b0f06bd44cd577b757d3f267bc35fe4d
treeb4c8eeec7bbd4b0bc3d91125d81941d9f004d4a7
parenta926592f5e4e900f3fa903298c4619a131e60963
bnx2x: Don't release PCI bars on shutdown

The bnx2x driver in its pci shutdown() callback releases its pci bars (in the
same manner it does during its pci remove() callback).
During a system reboot while VFs are enabled, its possible for the VF's remove
to be called (as a result of pci_disable_sriov()) after its shutdown callback
has already finished running; This will cause a paging request fault as the VF
tries to access the pci bar which it has previously released, crashing the
system.

This patch further differentiates the shutdown and remove callbacks, preventing the
pci release procedures from being called during shutdown.

Signed-off-by: Yuval Mintz <yuvalmin@broadcom.com>
Signed-off-by: Ariel Elior <ariele@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c