]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
ALSA: ppc: remove redundant checks in PS3 driver probe
authorLeonard Goehrs <l.goehrs@pengutronix.de>
Fri, 27 Nov 2020 15:22:59 +0000 (16:22 +0100)
committerTakashi Iwai <tiwai@suse.de>
Sat, 28 Nov 2020 08:49:19 +0000 (09:49 +0100)
commite4e1d47c7906cf108584c617c0b2ba32ed5428ed
tree66379fd264bdac1d7ec0f240a8c9ee981fd6d5aa
parent5c7797022fe9a95a4417c75fa59a1a2bfdc5a3be
ALSA: ppc: remove redundant checks in PS3 driver probe

The check for the FW_FEATURE_PS3_LV1 firmware feature is already performed
in ps3_system_bus_init() before registering the driver. So if the probe
function is actually used, this feature is already known to be available.

The check for the match id is also superfluous; the condition is always
true because the bus' match function (ps3_system_bus_match()) only
considers this driver for devices having:
dev->match_id == snd_ps3_bus_driver_info.match_id.

Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Leonard Goehrs <l.goehrs@pengutronix.de>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Tested-by: Geoff Levand <geoff@infradead.org>
Link: https://lore.kernel.org/r/20201127152259.1470079-1-l.goehrs@pengutronix.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/ppc/snd_ps3.c