]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
drm/i915: Account for scale factor when calculating initial phase
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Mon, 29 Oct 2018 18:18:20 +0000 (20:18 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Tue, 13 Nov 2018 15:00:35 +0000 (17:00 +0200)
commite7a278a329dd8aa2c70c564849f164cb5673689c
tree81fe5824b0dd8db8dd1e030a86cd400c12a3c077
parentca0026790eface29d355c96964207fd393a2f33a
drm/i915: Account for scale factor when calculating initial phase

To get the initial phase correct we need to account for the scale
factor as well. I forgot this initially and was mostly looking at
heavily upscaled content where the minor difference between -0.5
and the proper initial phase was not readily apparent.

And let's toss in a comment that tries to explain the formula
a little bit.

v2: The initial phase upper limit is 1.5, not 24.0!

Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Fixes: 0a59952b24e2 ("drm/i915: Configure SKL+ scaler initial phase correctly")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20181029181820.21956-1-ville.syrjala@linux.intel.com
Tested-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Tested-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> #irc
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> #irc
drivers/gpu/drm/i915/intel_display.c
drivers/gpu/drm/i915/intel_drv.h
drivers/gpu/drm/i915/intel_sprite.c