]> git.proxmox.com Git - mirror_qemu.git/commit
fw_cfg: Fix -boot reboot-timeout error checking
authorLi Qiang <liq3ea@gmail.com>
Wed, 21 Nov 2018 05:10:25 +0000 (21:10 -0800)
committerPhilippe Mathieu-Daudé <philmd@redhat.com>
Fri, 4 Jan 2019 14:30:52 +0000 (15:30 +0100)
commitee5d0f89de3e53cdb0dcf51acc1502b310ed3bd2
treecf2978fedf0fa852333168ba137cddb58500d520
parent6912bb0b3d3b140c70d8cdfd2dff77f9890d7f12
fw_cfg: Fix -boot reboot-timeout error checking

fw_cfg_reboot() gets option parameter "reboot-timeout" with
qemu_opt_get(), then converts it to an integer by hand. It neglects to
check that conversion for errors, and fails to reject negative values.
Positive values above the limit get reported and replaced by the limit.
This patch checks for conversion errors properly, and reject all values
outside 0...0xffff.

Signed-off-by: Li Qiang <liq3ea@gmail.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <1542777026-2788-3-git-send-email-liq3ea@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
hw/nvram/fw_cfg.c
vl.c