]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
media: i2c: imx219: Fix binning for RAW8 capture
authorJai Luthra <j-luthra@ti.com>
Tue, 17 Jan 2023 08:16:23 +0000 (09:16 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Mon, 6 Feb 2023 07:42:28 +0000 (08:42 +0100)
commitef86447e775fb1f2ced00d4c7fff2c0a1c63f165
tree530d41599e2fe9170f7ef07d648b307232ecdbc8
parentc699ce1a3838465fb87ecd951f0819404e70030a
media: i2c: imx219: Fix binning for RAW8 capture

2x2 binning works fine for RAW10 capture, but for RAW8 1232p mode it
leads to corrupted frames [1][2].

Using the special 2x2 analog binning mode fixes the issue, but causes
artefacts for RAW10 1232p capture. So here we choose the binning mode
depending upon the frame format selected.

As both binning modes work fine for 480p RAW8 and RAW10 capture, it can
share the same code path as 1232p for selecting binning mode.

[1] https://forums.raspberrypi.com/viewtopic.php?t=332103
[2] https://github.com/raspberrypi/libcamera-apps/issues/281

Fixes: 22da1d56e982 ("media: i2c: imx219: Add support for RAW8 bit bayer format")
Signed-off-by: Jai Luthra <j-luthra@ti.com>
Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/i2c/imx219.c