]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
phy: mediatek: allow compile-testing the hdmi phy
authorArnd Bergmann <arnd@arndb.de>
Fri, 4 Dec 2020 13:56:43 +0000 (14:56 +0100)
committerVinod Koul <vkoul@kernel.org>
Sat, 5 Dec 2020 07:50:38 +0000 (13:20 +0530)
commitf5f6e01f9164040ba120f30522efdb4deceb529a
tree0520b9f23a3dd9369814fb1d514788176d69718a
parentab7dd2008b29e48cff216aa984902d59b583d36d
phy: mediatek: allow compile-testing the hdmi phy

Compile-testing the DRM_MEDIATEK_HDMI driver shows two missing
dependencies, one results in a link failure:

arm-linux-gnueabi-ld: drivers/phy/mediatek/phy-mtk-hdmi.o: in function `mtk_hdmi_phy_probe':
phy-mtk-hdmi.c:(.text+0xd8): undefined reference to `__clk_get_name'
arm-linux-gnueabi-ld: phy-mtk-hdmi.c:(.text+0x12c): undefined reference to `devm_clk_register'
arm-linux-gnueabi-ld: phy-mtk-hdmi.c:(.text+0x250): undefined reference to `of_clk_add_provider'
arm-linux-gnueabi-ld: phy-mtk-hdmi.c:(.text+0x298): undefined reference to `of_clk_src_simple_get'

The other one is a harmless warning:

WARNING: unmet direct dependencies detected for PHY_MTK_HDMI
  Depends on [n]: ARCH_MEDIATEK [=n] && OF [=y]
  Selected by [y]:
  - DRM_MEDIATEK_HDMI [=y] && HAS_IOMEM [=y] && DRM_MEDIATEK [=y]

Fix these by adding dependencies on CONFIG_OF and CONFIG_COMMON_CLK.
With that done, there is also no reason against adding
CONFIG_COMPILE_TEST.

Fixes: b28be59a2e26 ("phy: mediatek: Move mtk_hdmi_phy driver into drivers/phy/mediatek folder")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20201204135650.2744481-1-arnd@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/mediatek/Kconfig