]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
ixgbe: handle close/suspend race with netif_device_detach/present
authorEmil Tantilov <emil.s.tantilov@intel.com>
Fri, 11 Nov 2016 18:07:47 +0000 (10:07 -0800)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Tue, 3 Jan 2017 21:03:36 +0000 (13:03 -0800)
commitf7f37e7ff2b9b7eff7fbd035569cab35896869a3
tree1db22aa7dabc519edd5ef39aaeae0cfbb4bd7abf
parentf215266470dfe86196a31fe0725a86cea77f9a18
ixgbe: handle close/suspend race with netif_device_detach/present

When an interface is part of a namespace it is possible that
ixgbe_close() may be called while __ixgbe_shutdown() is running
which ends up in a double free WARN and/or a BUG in free_msi_irqs().

To handle this situation we extend the rtnl_lock() to protect the
call to netif_device_detach() and ixgbe_clear_interrupt_scheme()
in __ixgbe_shutdown() and check for netif_device_present()
to avoid clearing the interrupts second time in ixgbe_close();

Also extend the rtnl lock in ixgbe_resume() to netif_device_attach().

Signed-off-by: Emil Tantilov <emil.s.tantilov@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c