]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
net/tcp_ao: Don't leak ao_info on error-path
authorDmitry Safonov <0x7f454c46@gmail.com>
Wed, 19 Jun 2024 00:29:04 +0000 (01:29 +0100)
committerJakub Kicinski <kuba@kernel.org>
Thu, 20 Jun 2024 00:30:19 +0000 (17:30 -0700)
commitf9ae848904289ddb16c7c9e4553ed4c64300de49
treecfd999cd5763b87458e2b5a8865f0f7c3a5a3837
parent74382aebc9035470ec4c789bdb0d09d8c14f261e
net/tcp_ao: Don't leak ao_info on error-path

It seems I introduced it together with TCP_AO_CMDF_AO_REQUIRED, on
version 5 [1] of TCP-AO patches. Quite frustrative that having all these
selftests that I've written, running kmemtest & kcov was always in todo.

[1]: https://lore.kernel.org/netdev/20230215183335.800122-5-dima@arista.com/

Reported-by: Jakub Kicinski <kuba@kernel.org>
Closes: https://lore.kernel.org/netdev/20240617072451.1403e1d2@kernel.org/
Fixes: 0aadc73995d0 ("net/tcp: Prevent TCP-MD5 with TCP-AO being set")
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Safonov <0x7f454c46@gmail.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/20240619-tcp-ao-required-leak-v1-1-6408f3c94247@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ipv4/tcp_ao.c