]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
sched/rt: Fix bad task migration for rt tasks
authorSchspa Shi <schspa@gmail.com>
Sun, 28 Aug 2022 17:03:02 +0000 (01:03 +0800)
committerPeter Zijlstra <peterz@infradead.org>
Fri, 21 Apr 2023 11:24:21 +0000 (13:24 +0200)
commitfeffe5bb274dd3442080ef0e4053746091878799
tree0e69d00d399b44cc97094d2828d993fe6282fe22
parent223baf9d17f25e2608dbdff7232c095c1e612268
sched/rt: Fix bad task migration for rt tasks

Commit 95158a89dd50 ("sched,rt: Use the full cpumask for balancing")
allows find_lock_lowest_rq() to pick a task with migration disabled.
The purpose of the commit is to push the current running task on the
CPU that has the migrate_disable() task away.

However, there is a race which allows a migrate_disable() task to be
migrated. Consider:

  CPU0                                    CPU1
  push_rt_task
    check is_migration_disabled(next_task)

                                          task not running and
                                          migration_disabled == 0

    find_lock_lowest_rq(next_task, rq);
      _double_lock_balance(this_rq, busiest);
        raw_spin_rq_unlock(this_rq);
        double_rq_lock(this_rq, busiest);
          <<wait for busiest rq>>
                                              <wakeup>
                                          task become running
                                          migrate_disable();
                                            <context out>
    deactivate_task(rq, next_task, 0);
    set_task_cpu(next_task, lowest_rq->cpu);
      WARN_ON_ONCE(is_migration_disabled(p));

Fixes: 95158a89dd50 ("sched,rt: Use the full cpumask for balancing")
Signed-off-by: Schspa Shi <schspa@gmail.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
Reviewed-by: Valentin Schneider <vschneid@redhat.com>
Tested-by: Dwaine Gonyier <dgonyier@redhat.com>
kernel/sched/deadline.c
kernel/sched/rt.c