Merge remote-tracking branch 'frr/master' into warnings

[mirror_frr.git] / zebra / rtread_getmsg.c

diff --git a/zebra/rtread_getmsg.c b/zebra/rtread_getmsg.c
index 8e5d7fbdbee5d5d6dfc16c669bf0d97f5377e23c..40982639c14dc12974da31f4a6a0831ef64abca4 100644 (file)
--- a/zebra/rtread_getmsg.c
+++ b/zebra/rtread_getmsg.c
@@ -28,10 +28,12 @@
 #include "if.h"
 #include "vrf.h"
 #include "vty.h"
+#include "lib_errors.h"
 
 #include "zebra/rib.h"
 #include "zebra/rt.h"
 #include "zebra/zebra_pbr.h"
+#include "zebra/zebra_errors.h"
 
 /* Thank you, Solaris, for polluting application symbol namespace. */
 #undef hook_register
@@ -119,8 +121,8 @@ void route_read(struct zebra_ns *zns)
        int flags, dev, retval, process;
 
        if ((dev = open(_PATH_GETMSG_ROUTE, O_RDWR)) == -1) {
-               zlog_warn("can't open %s: %s", _PATH_GETMSG_ROUTE,
-                         safe_strerror(errno));
+               flog_err_sys(LIB_ERR_SYSTEM_CALL, "can't open %s: %s",
+                            _PATH_GETMSG_ROUTE, safe_strerror(errno));
                return;
        }
 
@@ -141,7 +143,8 @@ void route_read(struct zebra_ns *zns)
        flags = 0;
 
        if (putmsg(dev, &msgdata, NULL, flags) == -1) {
-               zlog_warn("putmsg failed: %s", safe_strerror(errno));
+               flog_err_sys(LIB_ERR_SOCKET, "putmsg failed: %s",
+                            safe_strerror(errno));
                goto exit;
        }
 
@@ -153,8 +156,9 @@ void route_read(struct zebra_ns *zns)
                retval = getmsg(dev, &msgdata, NULL, &flags);
 
                if (retval == -1) {
-                       zlog_warn("getmsg(ctl) failed: %s",
-                                 safe_strerror(errno));
+                       flog_err_sys(LIB_ERR_SYSTEM_CALL,
+                                    "getmsg(ctl) failed: %s",
+                                    safe_strerror(errno));
                        goto exit;
                }
 
@@ -167,10 +171,10 @@ void route_read(struct zebra_ns *zns)
 
                if ((size_t)msgdata.len >= sizeof(struct T_error_ack)
                    && TLIerr->PRIM_type == T_ERROR_ACK) {
-                       zlog_warn("getmsg(ctl) returned T_ERROR_ACK: %s",
-                                 safe_strerror((TLIerr->TLI_error == TSYSERR)
-                                                       ? TLIerr->UNIX_error
-                                                       : EPROTO));
+                       zlog_debug("getmsg(ctl) returned T_ERROR_ACK: %s",
+                                  safe_strerror((TLIerr->TLI_error == TSYSERR)
+                                                        ? TLIerr->UNIX_error
+                                                        : EPROTO));
                        break;
                }
 
@@ -182,7 +186,7 @@ void route_read(struct zebra_ns *zns)
                    || TLIack->PRIM_type != T_OPTMGMT_ACK
                    || TLIack->MGMT_flags != T_SUCCESS) {
                        errno = ENOMSG;
-                       zlog_warn("getmsg(ctl) returned bizarreness");
+                       zlog_debug("getmsg(ctl) returned bizarreness");
                        break;
                }
 
@@ -211,20 +215,21 @@ void route_read(struct zebra_ns *zns)
                        retval = getmsg(dev, NULL, &msgdata, &flags);
 
                        if (retval == -1) {
-                               zlog_warn("getmsg(data) failed: %s",
-                                         safe_strerror(errno));
+                               flog_err_sys(LIB_ERR_SYSTEM_CALL,
+                                            "getmsg(data) failed: %s",
+                                            safe_strerror(errno));
                                goto exit;
                        }
 
                        if (!(retval == 0 || retval == MOREDATA)) {
-                               zlog_warn("getmsg(data) returned %d", retval);
+                               zlog_debug("getmsg(data) returned %d", retval);
                                goto exit;
                        }
 
                        if (process) {
                                if (msgdata.len % sizeof(mib2_ipRouteEntry_t)
                                    != 0) {
-                                       zlog_warn(
+                                       zlog_debug(
                                                "getmsg(data) returned "
                                                "msgdata.len = %d (%% sizeof (mib2_ipRouteEntry_t) != 0)",
                                                msgdata.len);