]> git.proxmox.com Git - mirror_frr.git/commit
bgpd: Finalize group-overrides for peer/AF attrs
authorPascal Mathis <mail@pascalmathis.com>
Thu, 14 Jun 2018 16:03:33 +0000 (18:03 +0200)
committerPascal Mathis <mail@pascalmathis.com>
Tue, 19 Jun 2018 16:18:47 +0000 (18:18 +0200)
commitc5a806dec1d41a5ee18e5b248227cf347736d2cb
tree49db2d8354157c6977cf095c629ae55da3882b62
parentb26644f3c997659392d7f5dbeb677cc774153818
bgpd: Finalize group-overrides for peer/AF attrs

This commit finalizes the previous commits which introduced a generic
approach for making all BGP peer and address-family attributes
overrideable by keeping track of the configuration origin in separate
internal structures.

First of all, the test suite was greatly extended to also check the
internal data structures of peer/AF attributes, so that inheritance for
internal values like 'peer->weight' is also being checked in all cases.

This revealed some smaller issues in the implementation, which were also
fixed in this commit. The test suite now fully passes and covers all the
usual situations that should normally occur.

Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
(cherry picked from commit 4c3911425c6fbfdd5014fcef3fc37ced69a7c408)
bgpd/bgpd.c
tests/bgpd/test_peer_attr.c