Merge pull request #714 from opensourcerouting/cli_magic_defpy

CLI magic: part 1 (DEFPY)

redhat: On CentOS/RedHat 6, use python27-devel from iuscommunity.org

FRR requires now Python 2.7 development libraries, but CentOS 6
does not provide this (not in main and not in EPEL library)
This is only a build limitation.

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>

redhat: python-devel is now a build requirement for main package

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>

debian: python3-dev is now a build requirement for main package

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>

doc: Update to reflect Python Development Library dependency for all builds

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>

Merge pull request #757 from donaldsharp/extract_sort

vtysh: Sort ordering of vtysh_cmd.c

Merge pull request #748 from qlyoung/fix-vtysh-exit

lib: actually exit when asked to 'do' so

Merge pull request #747 from qlyoung/fix-various-vtysh-do

vtysh: fix various show commands

vtysh: Sort ordering of vtysh_cmd.c

When we created the vtysh_cmd.c file the vtysh_cmd.c output
is slightly different for every run, even when none of the
inputs have changed.

Add the ability to sort the output so that the output is
the same for every build.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Merge pull request #749 from qlyoung/fix-json-cli

lib: look at the correct token for json

lib: look at the correct token for json

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

lib: actually exit when asked to do so

When vtysh sends 'exit' to a daemon, we set the vty->status to
VTY_CLOSE but never actually close the connection. Lovely.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vtysh: fix various show commands

need 'do' to force ENABLE_NODE

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

Merge pull request #745 from qlyoung/fix-lookup

*: simplify log message lookup

*: simplify log message lookup

log.c provides functionality for associating a constant (typically a
protocol constant) with a string and finding the string given the
constant. However this is highly delicate code that is extremely prone
to stack overflows and off-by-one's due to requiring the developer to
always remember to update the array size constant and to do so correctly
which, as shown by example, is never a good idea.b

The original goal of this code was to try to implement lookups in O(1)
time without a linear search through the message array. Since this code
is used 99% of the time for debugs, it's worth the 5-6 additional cmp's
worst case if it means we avoid explitable bugs due to oversights...

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

Merge pull request #741 from qlyoung/fix-vtysh-buffer-overrun

vtysh: fix stack buffer overflow

Merge pull request #698 from dslicenc/cm16737-srgb-block

zebra: define default segment routing global block values

Merge pull request #707 from donaldsharp/debian_babel

tools: Fix startup to include babel

Merge pull request #728 from donaldsharp/owner

bgpd: Remove unset table.owner

Merge pull request #731 from qlyoung/fix-bgp-misc-cli

bgpd: fix misc cli ranges & config writes

Merge pull request #732 from qlyoung/coverity-memes

lib: termtable coverity warnings

Merge pull request #730 from opensourcerouting/rbtree-improvement

RB tree improvement

vtysh: fix stack buffer overflow

VARIABLE accepts arbitrary input

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

lib: fix __unused compilation on old platforms

Expand the macro __attribute__ to avoid problem with old platforms that
do not define this.

lib: rename rb_tree to fix NetBSD compilation

Change rb_tree struct name to rbt_tree to avoid conflicts with NetBSD.

lib: Fix ordering of RB Tree

So the *bsd implementations of RB Tree's for older
platforms use a macro implementation.  New platforms
have converted to a function implementation that uses
a different calling parameter list.  So when
we attempt to build FRR on older *bsd implementations
the macro's and functions do not interact too well.

As a workaround put the openbsd-tree.h #include
inside of zebra.h at a point before the particular
platforms version is included.  Since we use
the same #if guard for the header we should be ok.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

ldpd: fix fallouts from the rb-tree conversion

Signed-off-by: Renato Westphal <renato@openbsd.org>

Merge pull request #725 from donaldsharp/vrf_completion

Vrf completion

Merge pull request #702 from opensourcerouting/ldpd-cli-rewrite

ldpd: convert cli and get rid of the xml interface

bgpd: fix misc cli ranges & config writes

* Ranges for some MED were 2^32 - 2 instead of 2^32 - 1
* Use correct printf specifiers for unsigned values
* Some drive-by CLI collapsing and simplification

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

lib: termtable coverity warnings

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

ldpd: update copyright information

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>

ldpd: convert cli and get rid of the xml interface

The xml2cli.pl script was useful years ago when the vty code was very
rudimentary. This is not the case anymore, so convert all ldpd CLI
commands to use DEFUNs directly and get rid of the XML interface.

The benefits are:
* Consistency with the other daemons;
* One less build dependency (the LibXML perl module);
* Easier to add new commands.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>

bgpd: Fix as per Code Review comment

Add ending value in the array.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

lib, vtysh, zebra: Fix per CR comments

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

bgpd: Add view/vrf auto completion to commands

Modify the '<view|vrf> NAME' commands to allow auto-completion
of available choices.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

*: Add vrf autocompletion for commands

Switch NAME to VRFNAME and add vrf autocompletion
to commands that have them

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Merge pull request #718 from qlyoung/fix-vtysh-shit

lib: allow 'do' commands in ENABLE_NODE

Merge pull request #726 from chiragshah6/pim_dev

pimd: move variable declartion outside of switch

Merge pull request #620 from qlyoung/termtable

lib: add table generator

lib: allow 'do' commands in ENABLE_NODE

'do' is syntax sugar that allows the user to execute a command under
ENABLE_NODE when in another CLI node. If the user is already in
ENABLE_NODE, use of 'do' was previously disallowed. This patch allows it
because it makes it easier for us to hack around certain instances of
the node synchronization problem with vtysh.

Also included is a fix for one of these problems.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

lib: fix a possible NULL deference

Silences a warning generated by clang.

lib: improve the RB implementation

Switch the RB tree implementation completely to the new dlg@'s version
that uses pre-declared functions instead of macros for tree functions.

Original e-mail/diff:
https://marc.info/?l=openbsd-tech&m=147087487111068&w=2

Pros:

* Reduces the amount of code that the usage of those macros generate
* Allows the compiler to do a better compile-time check job
* Might have better i-cache utilization since the tree code is shared

Con:

* dlg@ benchmarks shows it has 'very slightly slower' insertions
* imported RB_* code must adapt the following calls:
  RB_INIT(), RB_GENERATE(), RB_ROOT(), RB_EMPTY(), make compare
  functions use 'const' (if not already) and maybe others.

lib: termtable MTYPE_TMP -> MTYPE_TTABLE

And some style nits.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

lib: add table generator

Allows for easy preparation of tabular output.

Supports:
 -- Padding
 -- Alignment
 -- Styling

bgpd: Remove unset table.owner

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

pimd: move variable declartion outside of switch

To Address ICC (intel CC) warning, moving variables
declaration out of switch statement.

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>

Merge pull request #711 ("Coverity munging")

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

ospfd: fix typo in error message

... and print the invalid input value

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

Merge pull request #705 from dwalton76/bgpd-show-neighbor-community

bgpd: "no neighbor x.x.x.x send-community" not displayed correctly

lib: fix protocol name array size

Oops.  Fixes #715.

Reported-by: Daniel Walton <dwalton@cumulusnetworks.com>
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

Merge pull request #716 from dwalton76/show-route-map

lib: "show route-map" is missing from the parser

lib: "show route-map" is missing from the parser

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

lib: fix CLI parser memleak

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

bgpd: (demo) apply some DEFPY()

(This was intended as further demonstration of the DEFPY code, but it
might as well go into the tree.)

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

lib: use DEFPY() for plist.c

Shorten lib/plist.c by combining the various command variants...

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

doc: CLI: document DEFPY() usage

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

tests: cli: unit test DEFPY() + clidef.py

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

python: clidef.py

Adds "DEFPY()" which invokes an additional layer of preprocessing, so
that we get pre-parsed and named function arguments for the CLI.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

lib: clippy the assistant

Wraps the command parsing code for Python, so we can use it to do fancy
preprocessing and replace extract.pl.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

build: fix some cross-compilation issues

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

zebra: Remove unused testzebra and ancillary files

The testzebra command was unused as well as unmaintained.
The NS and VRF changes never made into testzebra so when
you actually ran testzebra it would just crash due to
uninitialized assumptions.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

eigrpd: Fix integer overflow possibility

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

pimd: Cleanup ifp->info setup

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

ospfclient: Free up leaked resources in error path

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

*: Clean up call into inet_aton

In the few places where we were not checking the return code
for inet_aton, do so.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Merge branch 'stable/3.0'

Dropped:
redhat/README.rpm_build.md
redhat/daemons
redhat/frr.init
redhat/frr.logrotate
redhat/frr.spec.in

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

Merge pull request #681 (ASAN warnings)

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

tools: Fix startup to include babel

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Merge pull request #687 (nexthop refactoring)

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

Merge pull request #624 "Babel"

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

babeld/eigrpd: flip VTY ports & fix rpm

babeld was 2609 previously, and this was still marked in SERVICES.
Let's flip it back before we have a release out with it.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

Merge pull request #703 from donaldsharp/nl_pid

zebra: When calling netlink, set the nl_pid as appropriate

Merge pull request #700 "Coverity high"

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

Merge pull request #678

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

babeld: install directly connected IPv4 as such

babeld would install "1.2.3.4 on eth0" as "1.2.3.4 via 1.2.3.4 on eth0".
Remove the superfluous nexthop and send to zebra as directly-connected
route.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

Merge remote-tracking branch 'frr/master' into pull-624

bgpd: "no neighbor x.x.x.x send-community" not displayed correctly

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
We would only diplay one "no neighbor 2.2.2.2 send-community XYZ" but
there might be multiple that need to be displayed.

zebra: When calling netlink, set the nl_pid as appropriate

This will allow us to further know that we originated the message.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

zebra: Fix memory leak

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

zebra: Fix uninitialized memory access with src_p

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

eigrpd: Correctly size the dump data

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

eigrpd: Use correct memory operation

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

eigrpd: Fix leak of ep

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

eigrpd: Cleanup leaked dest_addr

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

eigrpd: Fix use after free

Signed-off-by: Donald Sharp <sharpd@Cumulusnetworks.com>

zebra: Fix possible buffer overrun

Use the correct size of the string.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

bgpd: Free allocated stream in error code

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

bgpd: fix memleak with 'show ip bgp vrf ...'

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

Merge pull request #679 from dslicenc/cm16513

bgpd: add "set label-index" route-map option

Merge pull request #694 from qlyoung/event-loop

*: remove THREAD_BACKGROUND

isisd: fix heap uaf, round 2

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

Merge pull request #692 from donaldsharp/meta_queue_fix

zebra: Fix the metaq to be aware of all routing protocols we could see

Merge pull request #693 from donaldsharp/more_newlines_missing

bgpd: Fix missing newline

Merge pull request #697 from donaldsharp/rt_proto_fixes

tools, zebra: Fix netlink notification of who owns the routes

Merge pull request #696 from donaldsharp/disable_rtadv

zebra: Fix --disable-rtadv to actually compile

zebra: define default segment routing global block values

Standard define the default SRGB range from 16000 to 23999.  This
commit defines these default values for frr.

Ticket: CM-16737
Signed-off-by: Don Slice <dslice@cumulusnetworks.com>
Reviewed-by: CCR-6347

zebra: In which RTPROT_BABEL is hard

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

zebra: For older distributions RTPROT_BABEL might not be defined

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

tools, zebra: Allow zebra to insert babel routes as babel

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>