]> git.proxmox.com Git - mirror_ifupdown2.git/log
mirror_ifupdown2.git
5 years agoman: ifquery: fix conflicting documentation about ifquery -i flag
Julien Fortin [Mon, 1 Oct 2018 14:28:27 +0000 (16:28 +0200)]
man: ifquery: fix conflicting documentation about ifquery -i flag

Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agoaddon: ethtool: link-speed: add 10 to valid values array
Julien Fortin [Mon, 1 Oct 2018 14:23:49 +0000 (16:23 +0200)]
addon: ethtool: link-speed: add 10 to valid values array

Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agodebian: changelog: add link-fec changelog entry (release 1.2.1)
Julien Fortin [Tue, 9 Oct 2018 19:31:44 +0000 (21:31 +0200)]
debian: changelog: add link-fec changelog entry (release 1.2.1)

Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agoREADME: update deb version (1.2.1)
Julien Fortin [Tue, 9 Oct 2018 15:38:40 +0000 (17:38 +0200)]
README: update deb version (1.2.1)

5 years agoaddons: bridge: add "none" to the bridge-ports validvals (closes #75)
Julien Fortin [Mon, 24 Sep 2018 15:59:14 +0000 (17:59 +0200)]
addons: bridge: add "none" to the bridge-ports validvals (closes #75)

--syntax-check was failing because "none" was missing in the validvals list for bridge-ports
closes #75

Reported-by: Alexandre Derumier <aderumier@odiso.com>
5 years agoREADME: update dependency list: fakeroot, build-essential
Julien Fortin [Mon, 24 Sep 2018 08:10:06 +0000 (10:10 +0200)]
README: update dependency list: fakeroot, build-essential

5 years agoREADME: update build dependency list
Julien Fortin [Mon, 24 Sep 2018 08:06:30 +0000 (10:06 +0200)]
README: update build dependency list

build dependency line was missing 'devscripts'

5 years agoaddons: ethtool: fix indentation error for link-fec attr
Anton Lindström [Sun, 9 Sep 2018 17:28:31 +0000 (19:28 +0200)]
addons: ethtool: fix indentation error for link-fec attr

Signed-off-by: Anton Lindström <carlantonlindstrom@gmail.com>
Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agodebian: changelog: update changelog for release 1.2.1
Julien Fortin [Sun, 2 Sep 2018 16:38:01 +0000 (18:38 +0200)]
debian: changelog: update changelog for release 1.2.1

Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agoaddons: vrf: fix link-down yes on vrf throws an exception
Julien Fortin [Mon, 20 Aug 2018 07:15:32 +0000 (09:15 +0200)]
addons: vrf: fix link-down yes on vrf throws an exception

before the patch we can see that ifreload is displaying an error
with the example config

$ ifquery -a
auto lo
iface lo inet loopback

auto eth0
iface eth0 inet dhcp

auto swp1
iface swp1
      vrf blue
         link-down yes

auto blue
iface blue
      vrf-table auto

$ ifreload -a
error: eth0: vrf blue not around, skipping vrf config
$ echo $?
1
$

$ # applying patch
$ ifreload -a
$ echo $?
0

Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agoaddons: bridge: ports l2protocol tunnel: fix TypeError exception
Julien Fortin [Thu, 16 Aug 2018 10:31:36 +0000 (12:31 +0200)]
addons: bridge: ports l2protocol tunnel: fix TypeError exception

ifquery may fail on the following exception:

File "/usr/share/ifupdown2/addons/bridge.py", line 709, in _query_check_l2protocol_tunnel_lldp
     return ifla_brport_group_mask & 0x4000
 TypeError: unsupported operand type(s) for &: 'NoneType' and 'int'

Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agoifupdownaddons: mstpctlutils: cache empty 'showportdetail' results
Julien Fortin [Tue, 14 Aug 2018 16:49:39 +0000 (18:49 +0200)]
ifupdownaddons: mstpctlutils: cache empty 'showportdetail' results

mstpctl might return an empty result on: mstpctl showportdetail bridge json
the cache is not filled with an empty dict so next cache lookup will be a
cache miss and therefore, ifupdown2 thinks we need to fill the cache with fresh
data and will execute showportdetail again (resulting in calling mstpctl cmd
sometime 5 or 6 times in a row).

Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agoaddons: vlan: for ip link del use netlink rather than iproute2
Julien Fortin [Tue, 14 Aug 2018 16:48:58 +0000 (18:48 +0200)]
addons: vlan: for ip link del use netlink rather than iproute2

Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agoaddons: vlan: add vlan-raw-device add missing user config check
Julien Fortin [Fri, 10 Aug 2018 14:09:28 +0000 (16:09 +0200)]
addons: vlan: add vlan-raw-device add missing user config check

Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agoaddons: vlan: raw-device: check if cache value is valid before more checks
Julien Fortin [Fri, 10 Aug 2018 09:40:47 +0000 (11:40 +0200)]
addons: vlan: raw-device: check if cache value is valid before more checks

Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agoLinkUtils: addrgen: move disable_ipv6 check before MTU check
Julien Fortin [Fri, 10 Aug 2018 09:37:41 +0000 (11:37 +0200)]
LinkUtils: addrgen: move disable_ipv6 check before MTU check

if disable_ipv6 is on there's no need to check for the MTU

Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agoaddons: vlan: error out when vlan-raw-device config change on existing vlan
Julien Fortin [Thu, 9 Aug 2018 13:46:16 +0000 (15:46 +0200)]
addons: vlan: error out when vlan-raw-device config change on existing vlan

kernel doesn't support vlan raw-device change on existing vlan, user needs to
manually ifdown/ifup the device

[13:45:06] root:~ # ifquery vlan42
auto vlan42
iface vlan42
      address 42.42.42.42/24
      vlan-id 42
      vlan-raw-device swp1

[13:45:07] root:~ # ifup -a
[13:45:09] root:~ # echo $?
0
[13:45:10] root:~ # ip link show vlan42
34: vlan42@swp1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP mode DEFAULT group default
    link/ether 90:e2:ba:2c:b1:96 brd ff:ff:ff:ff:ff:ff
[13:45:13] root:~ # nano /etc/network/interfaces
[13:45:19] root:~ # ifquery vlan42
auto vlan42
iface vlan42
      address 42.42.42.42/24
      vlan-id 42
      vlan-raw-device swp2

[13:45:25] root:~ # ifreload -a
error: vlan42: cannot change vlan-raw-device from swp1 to swp2: operation not supported. Please delete the device with 'ifdown vlan42' and recreate it to apply the change.
[13:45:27] root:~ # echo $?
1
[13:45:30] root:~ #

Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agoLinkUtils: check device MTU and /proc/../disable_ipv6 before setting ipv6-addrgen
Julien Fortin [Thu, 9 Aug 2018 11:19:08 +0000 (13:19 +0200)]
LinkUtils: check device MTU and /proc/../disable_ipv6 before setting ipv6-addrgen

The minimum IPv6 MTU (ipv6 stack should handle at minmum this size)
is 1280 bytes. If you set the MTU below that then you can't really
have ipv6 addrconf follows the MTU changes and if it sees change
below 1280 then it disables ipv6 on the iface

$ ifquery swp1
auto swp1
iface swp1
      mtu 420

$ ifreload -a
error: swp1: cmd '/bin/ip -force -batch - [link set dev swp1 down
link set dev swp1 addrgenmode eui64
link set dev swp1 up
]' failed: returned 1 (RTNETLINK answers: Address family not supported by protocol
Command failed -:2
)

Reviewed-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agoREADME: update build instruction to switch to maste-next branch
Julien Fortin [Wed, 1 Aug 2018 09:30:28 +0000 (11:30 +0200)]
README: update build instruction to switch to maste-next branch

The building instruction didn't mention that users should checkout the master-next branch and build from it. This branch contains the lastest ifupdown2 version

5 years agoREADME: remove rst2man from dependency list
Julien Fortin [Wed, 1 Aug 2018 09:24:09 +0000 (11:24 +0200)]
README: remove rst2man from dependency list

5 years agodebian: changelog: add ip[6]-forward entry for new validvals
Julien Fortin [Mon, 30 Jul 2018 12:42:01 +0000 (14:42 +0200)]
debian: changelog: add ip[6]-forward entry for new validvals

Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agoaddons: addressvirtual: address-virtual-ipv6-addrgen reset to default if removed...
Julien Fortin [Mon, 23 Jul 2018 08:38:29 +0000 (10:38 +0200)]
addons: addressvirtual: address-virtual-ipv6-addrgen reset to default if removed from stanza

Ticket: CM-21656
Reviewed By: Roopa
Testing Done:

[8:39:13] root:~ # ifquery vlan1000
auto vlan1000
iface vlan1000
      address 192.168.10.1/24
      address fc00:10::1/64
      address-virtual 00:00:5e:00:01:01 192.168.10.1/24 fc00:10::1/64 fe80::1/64
      address-virtual-ipv6-addrgen off
      vlan-id 1000
      vlan-raw-device bridge

[8:39:18] root:~ # nano /etc/network/interfaces
[8:39:24] root:~ # ifquery vlan1000
auto vlan1000
iface vlan1000
      address 192.168.10.1/24
      address fc00:10::1/64
      address-virtual 00:00:5e:00:01:01 192.168.10.1/24 fc00:10::1/64 fe80::1/64
      vlan-id 1000
      vlan-raw-device bridge

[8:39:27] root:~ # ifreload -a -v |& grep addrgenmode
link set dev vlan1000-v0 addrgenmode eui64
[8:39:34] root:~ #

Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agoaddons: address: add yes, no, 1, 0 as valid values
Roopa Prabhu [Sun, 15 Jul 2018 04:54:48 +0000 (21:54 -0700)]
addons: address: add yes, no, 1, 0 as valid values

Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agoaddons: address: fix ifquery-check for ip(6)-forward 0/1 values
Julien Fortin [Mon, 16 Jul 2018 11:03:47 +0000 (13:03 +0200)]
addons: address: fix ifquery-check for ip(6)-forward 0/1 values

[18:18:12] root:~ # ifquery swp1
auto swp1
iface swp1
ip-forward 0
ip6-forward 0

[18:18:15] root:~ #
[18:18:16] root:~ # ifup swp1
[18:18:22] root:~ # echo $?
0
[18:18:23] root:~ # ifquery swp1 -c
auto swp1
iface swp1                                                          [pass]
ip-forward off                                              [pass]
ip6-forward off                                             [pass]

[18:18:27] root:~ #

Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agoipv6-addrgen: add ifquery check/running/ifreload support using netlink cache
Julien Fortin [Mon, 9 Jul 2018 22:18:39 +0000 (00:18 +0200)]
ipv6-addrgen: add ifquery check/running/ifreload support using netlink cache

[13:09:20] root:~ # ifquery -a
auto lo
iface lo inet loopback

auto eth0
iface eth0 inet dhcp

auto vlan1903
iface vlan1903
vlan-id 1903
vlan-raw-device bridge
ipv6-addrgen no
address-virtual-ipv6-addrgen no
address-virtual 00:00:5e:00:01:a3 2a06:c01:1:1903::1/64 fe80::1/64 185.98.123.1/24

auto bridge
iface bridge
bridge-ports swp1

[13:09:25] root:~ # ifup -a -v
info: loading builtin modules from ['/usr/share/ifupdown2/addons']
info: executing /var/lib/ifupdown2/hooks/get_reserved_vlan_range.sh
info: executing /sbin/sysctl net.bridge.bridge-allow-multiple-vlans
info: executing /bin/pidof mstpd
info: executing /bin/ip rule show
info: executing /bin/ip -6 rule show
info: address: using default mtu 1500
info: 'link_master_slave' is set. slave admin state changes will be delayed till the masters admin state change.
info: processing interfaces file /etc/network/interfaces
info: lo: running ops ...
info: netlink: ip link show
info: netlink: ip addr show
info: executing /bin/ip addr help
info: address metric support: KO
info: lo: netlink: ip link set dev lo up
info: reading '/proc/sys/net/mpls/conf/lo/input'
info: reading '/proc/sys/net/ipv4/conf/lo/forwarding'
info: reading '/proc/sys/net/ipv6/conf/lo/forwarding'
info: reading '/proc/sys/net/ipv4/conf/lo/accept_local'
info: executing /bin/systemctl is-enabled vxrd.service
info: eth0: running ops ...
info: executing /sbin/ethtool eth0
info: reading '/sys/class/net/eth0/speed'
info: reading '/sys/class/net/eth0/duplex'
info: eth0: netlink: ip link set dev eth0 up
info: dhclient4 already running on eth0. Not restarting.
info: reading '/proc/sys/net/mpls/conf/eth0/input'
info: reading '/proc/sys/net/ipv4/conf/eth0/forwarding'
info: reading '/proc/sys/net/ipv6/conf/eth0/forwarding'
info: reading '/proc/sys/net/ipv4/conf/eth0/accept_local'
info: swp1: running ops ...
info: executing /sbin/ethtool swp1
info: reading '/sys/class/net/swp1/speed'
info: reading '/sys/class/net/swp1/duplex'
info: executing /sbin/ethtool -s swp1  speed 1000 duplex full
info: reading '/proc/sys/net/mpls/conf/swp1/input'
info: reading '/proc/sys/net/ipv4/conf/swp1/accept_local'
info: bridge: running ops ...
info: bridge: netlink: ip link add bridge type bridge
info: bridge: apply bridge settings
info: bridge: set bridge-ageing 1800
info: bridge: set bridge-hashel 4096
info: bridge: set bridge-hashmax 4096
info: bridge: set bridge-mcstats on
info: reading '/sys/class/net/bridge/bridge/stp_state'
info: bridge: stp state reset, reapplying port settings
info: bridge: netlink: ip link set bridge type bridge with attributes
info: writing '1' to file /proc/sys/net/ipv6/conf/swp1/disable_ipv6
info: executing /bin/ip -force -batch - [link set dev swp1 master bridge
addr flush dev swp1
]
info: bridge: applying bridge port configuration: ['swp1']
info: bridge: swp1: set bridge-portprios 8
info: swp1: netlink: ip link set dev swp1: bridge slave attributes
info: executing /sbin/brctl showmcqv4src bridge
info: bridge: applying bridge configuration specific to ports
info: bridge: processing bridge config for port swp1
info: swp1: netlink: ip link set dev swp1 up
info: bridge: setting bridge mac to port swp1 mac
info: executing /bin/ip link set dev bridge address 90:e2:ba:2c:b1:96
info: executing /sbin/mstpctl showportdetail bridge json
info: executing /sbin/mstpctl showbridge json bridge
info: bridge: applying mstp configuration specific to ports
info: bridge: processing mstp config for port swp1
info: bridge: netlink: ip link set dev bridge up
info: reading '/proc/sys/net/mpls/conf/bridge/input'
info: executing /sbin/sysctl net.ipv4.conf.bridge.forwarding
info: executing /sbin/sysctl net.ipv6.conf.bridge.forwarding
info: executing /bin/ip -force -batch - [link set dev bridge down
link set dev bridge addrgenmode eui64
link set dev bridge up
]
info: reading '/proc/sys/net/ipv4/conf/bridge/accept_local'
info: vlan1903: running ops ...
info: vlan1903: netlink: ip link add link bridge name vlan1903 type vlan id 1903 protocol 802.1q
info: vlan1903: netlink: ip link set dev vlan1903 up
info: reading '/proc/sys/net/mpls/conf/vlan1903/input'
info: reading '/proc/sys/net/ipv4/conf/vlan1903/forwarding'
info: reading '/proc/sys/net/ipv6/conf/vlan1903/forwarding'
info: executing /bin/ip -force -batch - [link set dev vlan1903 down
link set dev vlan1903 addrgenmode none
link set dev vlan1903 up
]
info: vlan1903: netlink: ip link add link vlan1903 name vlan1903-v0 type macvlan mode private
info: executing /sbin/sysctl net.ipv6.conf.vlan1903-v0.accept_dad
info: executing /sbin/sysctl net.ipv6.conf.vlan1903-v0.accept_dad=0
info: executing /sbin/sysctl net.ipv6.conf.vlan1903-v0.dad_transmits
info: executing /sbin/sysctl net.ipv6.conf.vlan1903-v0.dad_transmits=0
info: executing /bin/ip -force -batch - [link set dev vlan1903-v0 addrgenmode none
link set dev vlan1903-v0 down
link set dev vlan1903-v0 address 00:00:5e:00:01:a3
link set dev vlan1903-v0 up
addr add 2a06:c01:1:1903::1/64 dev vlan1903-v0
addr add fe80::1/64 dev vlan1903-v0
addr add 185.98.123.1/24 dev vlan1903-v0
route del 2a06:c01:1:1903::/64 dev vlan1903-v0
route del fe80::/64 dev vlan1903-v0
route add 2a06:c01:1:1903::/64 dev vlan1903-v0 proto kernel metric 9999
route add fe80::/64 dev vlan1903-v0 proto kernel metric 9999
]
info: reading '/proc/sys/net/ipv4/conf/vlan1903/accept_local'
[13:09:29] root:~ #
[13:09:30] root:~ #
[13:09:30] root:~ # ifquery -a -c
auto lo
iface lo inet loopback

auto eth0
iface eth0 inet dhcp                                                [pass]

auto vlan1903
iface vlan1903                                                      [pass]
vlan-raw-device bridge                                      [pass]
vlan-id 1903                                                [pass]
ipv6-addrgen no                                             [pass]
address-virtual 00:00:5e:00:01:a3 2a06:c01:1:1903::1/64 fe80::1/64 185.98.123.1/24     [pass]
address-virtual-ipv6-addrgen no                             [pass]

auto bridge
iface bridge                                                        [pass]
bridge-ports swp1                                           [pass]

[13:09:33] root:~ #
[13:09:35] root:~ #
[13:09:35] root:~ # ifquery -a -r
auto vlan1903-v0
iface vlan1903-v0
ipv6-addrgen off
address 185.98.123.1/24
address 2a06:c01:1:1903::1/64

auto vlan1903
iface vlan1903
vlan-id 1903
vlan-protocol 802.1Q
vlan-raw-device bridge
ipv6-addrgen off
address-virtual 00:00:5e:00:01:a3 185.98.123.1/242a06:c01:1:1903::1/64
address-virtual-ipv6-addrgen off

auto bridge
iface bridge
bridge-vlan-stats off
bridge-mcstats 1
bridge-ports swp1
bridge-stp yes
mstpctl-portp2p  swp1=auto
mstpctl-treeportcost  swp1=20000
mstpctl-portautoedge  swp1=yes

auto swp1
iface swp1

auto eth0
iface eth0 inet dhcp

auto lo
iface lo inet loopback
mtu 65536

[13:09:38] root:~ # ip -d link show vlan1903
20: vlan1903@bridge: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP mode DEFAULT group default
    link/ether 90:e2:ba:2c:b1:96 brd ff:ff:ff:ff:ff:ff promiscuity 1
    vlan protocol 802.1Q id 1903 <REORDER_HDR> addrgenmode none
[13:09:50] root:~ # ip -d link show vlan1903-v0
21: vlan1903-v0@vlan1903: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP mode DEFAULT group default
    link/ether 00:00:5e:00:01:a3 brd ff:ff:ff:ff:ff:ff promiscuity 0
    macvlan  mode private addrgenmode none
[13:09:53] root:~ #
[13:09:56] root:~ # ip link set dev vlan1903-v0 addrgenmode eui64
[13:10:23] root:~ # ifquery -a -c
auto lo
iface lo inet loopback

auto eth0
iface eth0 inet dhcp                                                [pass]

auto vlan1903
iface vlan1903                                                      [fail]
vlan-raw-device bridge                                      [pass]
vlan-id 1903                                                [pass]
ipv6-addrgen no                                             [pass]
address-virtual 00:00:5e:00:01:a3 2a06:c01:1:1903::1/64 fe80::1/64 185.98.123.1/24     [pass]
address-virtual-ipv6-addrgen no                             [fail]

auto bridge
iface bridge                                                        [pass]
bridge-ports swp1                                           [pass]

[13:10:29] root:~ # ifquery -a -r
auto vlan1903-v0
iface vlan1903-v0
address 185.98.123.1/24
address 2a06:c01:1:1903::1/64

auto vlan1903
iface vlan1903
vlan-id 1903
vlan-protocol 802.1Q
vlan-raw-device bridge
ipv6-addrgen off
address-virtual 00:00:5e:00:01:a3 185.98.123.1/242a06:c01:1:1903::1/64
address-virtual-ipv6-addrgen on

auto bridge
iface bridge
bridge-vlan-stats off
bridge-mcstats 1
bridge-ports swp1
bridge-stp yes
mstpctl-portp2p  swp1=auto
mstpctl-treeportcost  swp1=20000
mstpctl-portautoedge  swp1=yes

auto swp1
iface swp1

auto eth0
iface eth0 inet dhcp

auto lo
iface lo inet loopback
mtu 65536

[13:10:33] root:~ #

Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agonlpacket: add decode support for IFLA_AF_SPEC (AF_UNSPEC) family - inet6 attributes
Julien Fortin [Mon, 9 Jul 2018 22:14:06 +0000 (00:14 +0200)]
nlpacket: add decode support for IFLA_AF_SPEC (AF_UNSPEC) family - inet6 attributes

This patch mostly adds support for IFLA_INET6_ADDR_GEN_MODE
nlmanager doesn't support multiple kernel version all the
other attributes like IFLA_INET6_CONF are based on DEVCONF_MAX
from _UAPI_IPV6_H.

Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agoaddons: addressvirtual: flush macvlan addr cache when setting addrgenmode
Julien Fortin [Mon, 9 Jul 2018 10:10:17 +0000 (12:10 +0200)]
addons: addressvirtual: flush macvlan addr cache when setting addrgenmode

When setting addrgenmode it is necessary to flap the macvlan
device. After flapping the device we also need to re-add all
the user configuration. The best way to add the user config
is to flush our internal address cache.

[10:12:10] root:~ # ifquery vlan1000
auto vlan1000
iface vlan1000
address 192.168.10.1/24
address fc00:10::1/64
address-virtual 00:00:5e:00:01:01 192.168.10.1/24 fc00:10::1/64 fe80::1/64
vlan-id 1000
vlan-raw-device bridge

[10:12:15] root:~ # ifup -a
[10:12:24] root:~ # echo $?
0
[10:12:26] root:~ # ifquery vlan1000 -c
auto vlan1000
iface vlan1000                                                      [pass]
vlan-raw-device bridge                                      [pass]
vlan-id 1000                                                [pass]
address 192.168.10.1/24                                     [pass]
address fc00:10::1/64                                       [pass]
address-virtual 00:00:5e:00:01:01 192.168.10.1/24 fc00:10::1/64 fe80::1/64     [pass]

[10:12:30] root:~ # ip -6 -o addr show vlan1000-v0
48: vlan1000-v0    inet6 fc00:10::1/64 scope global \       valid_lft forever preferred_lft forever
48: vlan1000-v0    inet6 fe80::200:5eff:fe00:101/64 scope link \       valid_lft forever preferred_lft forever
48: vlan1000-v0    inet6 fe80::1/64 scope link \       valid_lft forever preferred_lft forever
[10:12:33] root:~ #
[10:12:34] root:~ #
[10:12:34] root:~ # ifquery vlan1000
auto vlan1000
iface vlan1000
address 192.168.10.1/24
address fc00:10::1/64
address-virtual 00:00:5e:00:01:01 192.168.10.1/24 fc00:10::1/64 fe80::1/64
address-virtual-ipv6-addrgen off
vlan-id 1000
vlan-raw-device bridge

[10:12:39] root:~ #
[10:12:41] root:~ # ifreload -a -d
...
debug: vlan1000: up : running module addressvirtual
debug: vlan1000-v0: reset address cache <<<<<<<<<<<<<<<<<<<<<< without this reset ifupdown2 would be in a broken state
info: vlan1000: checking route entry ...
info: executing /bin/ip route get 192.168.10.0/24
info: netlink: ip link show dev vlan1000
info: netlink: ip link show dev vlan1000-v0
info: vlan1000-v0: netlink: ip link set dev vlan1000-v0 up
info: executing /bin/ip -force -batch - [link set dev vlan1000-v0 down
link set dev vlan1000-v0 addrgenmode none
link set dev vlan1000-v0 up
addr add 192.168.10.1/24 dev vlan1000-v0
addr add fc00:10::1/64 dev vlan1000-v0
addr add fe80::1/64 dev vlan1000-v0
]
...
[10:12:50] root:~ #
[10:12:51] root:~ # ip -6 -o addr show vlan1000-v0
48: vlan1000-v0    inet6 fc00:10::1/64 scope global \       valid_lft forever preferred_lft forever
48: vlan1000-v0    inet6 fe80::1/64 scope link \       valid_lft forever preferred_lft forever
[10:12:53] root:~ # ifquery vlan1000 -c
auto vlan1000
iface vlan1000                                                      [pass]
vlan-raw-device bridge                                      [pass]
vlan-id 1000                                                [pass]
address 192.168.10.1/24                                     [pass]
address fc00:10::1/64                                       [pass]
address-virtual 00:00:5e:00:01:01 192.168.10.1/24 fc00:10::1/64 fe80::1/64     [pass]

[10:13:03] root:~ # echo $?
0
[10:13:04] root:~ #

Reviewed-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agoaddons: bridge: fix check_valid_bridge for DRYRUN mode
Julien Fortin [Thu, 5 Jul 2018 15:24:16 +0000 (17:24 +0200)]
addons: bridge: fix check_valid_bridge for DRYRUN mode

Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agoaddons: mstpctl: bridge vlan-unaware: check brport running config before setting...
Julien Fortin [Tue, 3 Jul 2018 16:40:05 +0000 (18:40 +0200)]
addons: mstpctl: bridge vlan-unaware: check brport running config before setting attributes

when handling mstpctl attribute on vlan-unaware bridges we don't
check the running configuration of the bridge ports (cache) thus
misconfiguring some attributes on brports.

We first create a traditional bridge with:

auto bridge1
iface bridge1
    bridge-ports swp1 swp2
    bridge-vlan-aware no
We check the setting:

$ mstpctl showportdetail bridge1 swp1 | grep edge
  admin edge port    no                      auto edge port       yes
  oper edge port     yes                     topology change ack  no
We then add the setting for swp1:

auto swp1
iface swp1
    mstpctl-portautoedge no
We then do an ifreload -adv and we see two calls. First
info: executing /sbin/mstpctl setportautoedge bridge1 swp1 no

and then a little later
info: executing /sbin/mstpctl setportautoedge bridge1 swp1 yes

Reviewed-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agoaddons: bridge: warn users if bridge attributes are used under non-bridge stanza
Julien Fortin [Wed, 27 Jun 2018 20:45:24 +0000 (23:45 +0300)]
addons: bridge: warn users if bridge attributes are used under non-bridge stanza

This check is done without too much overhead because we rarely see a stanza
with more than a handful of attributes...

$ ifquery swp1
auto swp1
iface swp1
      bridge-vlan-aware yes
      bridge-stp off

$ ifup swp1 -v
...
info: swp1: running ops ...
warning: swp1: invalid use of bridge attribute (bridge-vlan-aware) on non-bridge stanza
warning: swp1: invalid use of bridge attribute (bridge-stp) on non-bridge stanza
..
$

Reviewed-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agoaddons: bridge: if device exists - check if device is really a bridge
Julien Fortin [Tue, 3 Jul 2018 08:06:40 +0000 (10:06 +0200)]
addons: bridge: if device exists - check if device is really a bridge

[18:43:47] root:~ # ip link show swp3
5: swp3: <BROADCAST,MULTICAST> mtu 1500 qdisc pfifo_fast state DOWN mode DEFAULT group default qlen 1000
    link/ether 08:00:27:bc:04:3c brd ff:ff:ff:ff:ff:ff
[18:43:48] root:~ #
[18:43:49] root:~ #
[18:43:50] root:~ # cat /etc/network/interfaces
auto lo
iface lo inet loopback

auto eth0
iface eth0 inet dhcp

auto swp3
iface swp3
bridge-vlan-aware yes
[18:43:50] root:~ #
[18:43:51] root:~ #
[18:43:51] root:~ # ifup -a
warning: swp3: error getting dependent interfaces (misconfiguration of bridge attribute(s) on existing non-bridge interface (swp3))
[18:43:56] root:~ # echo $?
1
[18:43:58] root:~ #

Reviewed-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agoaddons: addressvirtual: error in VRR mac address changes exit code (1)
Julien Fortin [Mon, 2 Jul 2018 10:20:07 +0000 (12:20 +0200)]
addons: addressvirtual: error in VRR mac address changes exit code (1)

$ ifquery -a
auto bridge
iface bridge
      bridge-vlan-aware yes
      bridge-ports swp1

auto bridge.2
iface bridge.2
      address-virtual 01:01:01:02:02:02 1.10.10.10/32

$ ifup -a
error: bridge.2: Multicast bit is set in the virtual mac address '01:01:01:02:02:02'
$ echo $?
1
$

Reviewed-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agoaddons: ppp: fixes PEP8 warning
Julien Fortin [Thu, 28 Jun 2018 15:42:48 +0000 (18:42 +0300)]
addons: ppp: fixes PEP8 warning

Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agodebian: changelog: 1.2.1: new entry: point-to-point protocol (ppp)
Julien Fortin [Thu, 28 Jun 2018 15:39:29 +0000 (18:39 +0300)]
debian: changelog: 1.2.1: new entry: point-to-point protocol (ppp)

New addon to create/configure ppp interfaces

Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agoaddons: ppp: Add support for master-next
Sven Auhagen [Mon, 25 Jun 2018 14:22:22 +0000 (16:22 +0200)]
addons: ppp: Add support for master-next
This commit fixes the ppp addon for the new master-next branch.

5 years agonlmanager: nlpacket: update AttributeMACAddress decode comments
Julien Fortin [Wed, 27 Jun 2018 18:46:38 +0000 (21:46 +0300)]
nlmanager: nlpacket: update AttributeMACAddress decode comments

this commit adds some explanation/comments in the decode function of the
AttributeMACAddress class. Some comments are moved around and placed
in the right location.

Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agoaddons: tunnel: pep8 refactoring
Julien Fortin [Wed, 27 Jun 2018 18:33:37 +0000 (21:33 +0300)]
addons: tunnel: pep8 refactoring

Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agonetlink: nlpacket AttributeMACAddress
Sven Auhagen [Wed, 27 Jun 2018 05:24:21 +0000 (07:24 +0200)]
netlink: nlpacket AttributeMACAddress

This commits fixes AttributeMACAddress for GREv6.
Error message: info: netlink: link dump failed: Length of MACAddress attribute not supported: 20
Reproducible by adding a GREv6 Tunnel:

auto gre1
iface gre1 inet tunnel
    mode ip6gre
    local 2001:1000:1000:1000::123
    endpoint 2001:1000:1000:2000::123
    address 192.168.123.1/29

In netlink The IFLA_ADDRESS and IFLA_BROADCAST attributes for all interfaces has been a
6-byte MAC address. But the GRE interface uses a 4-byte IP address and GREv6 uses a 16-byte IPv6 address for this
attribute. This patch allows for decoding a 16-byte value as an IP address.

5 years agoaddons: tunnel: Add support for master-next
Sven Auhagen [Wed, 27 Jun 2018 05:18:05 +0000 (07:18 +0200)]
addons: tunnel: Add support for master-next

This commit fixes the tunnel addon for the new master-next branch.

5 years agoaddons: addressvirtual: new policy (bool): addressvirtual_with_route_metric (default...
Julien Fortin [Mon, 25 Jun 2018 14:36:26 +0000 (16:36 +0200)]
addons: addressvirtual: new policy (bool): addressvirtual_with_route_metric (default: yes)

Ifupdown2 is now setting a default metric on macvlan ips. This policy will let
users disable this new default behavior. addressvirtual_with_route_metric is
boolean policy variable.

  addressvirtual_with_route_metric: yes|no|on|off|1|0 (default to yes)

$ cat /var/lib/ifupdown2/policy.d/addressvirtual.json
{
    "addressvirtual": {
        "module_globals": {
            "addressvirtual_with_route_metric": "no"
        }
    }
}

Reviewed-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agodebian: changelog: new entry for version 1.2.1
Julien Fortin [Tue, 26 Jun 2018 21:14:22 +0000 (00:14 +0300)]
debian: changelog: new entry for version 1.2.1

Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agoaddons: tunnel: complete backport by updating imports + PEP8 refactoring
Julien Fortin [Tue, 26 Jun 2018 20:59:59 +0000 (23:59 +0300)]
addons: tunnel: complete backport by updating imports + PEP8 refactoring

Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agoaddons: tunnel: dependent device fix
Sven Auhagen [Fri, 13 Apr 2018 17:32:04 +0000 (19:32 +0200)]
addons: tunnel: dependent device fix

5 years agoaddons: tunnel: get_dependent_ifacenames: tunnel-physdev dependency
Sven Auhagen [Sat, 7 Apr 2018 15:29:51 +0000 (17:29 +0200)]
addons: tunnel: get_dependent_ifacenames: tunnel-physdev dependency

5 years agoaddons: tunnel: fix tunnel v4 to v6 change
Sven Auhagen [Wed, 4 Apr 2018 18:53:32 +0000 (20:53 +0200)]
addons: tunnel: fix tunnel v4 to v6 change

5 years agoaddons: tunnel: add support for vti, ip6gre, ipip6, ip6ip6, vti6 tunnels
Sven Auhagen [Wed, 4 Apr 2018 17:49:34 +0000 (19:49 +0200)]
addons: tunnel: add support for vti, ip6gre, ipip6, ip6ip6, vti6 tunnels

5 years agoaddons: tunnel: Add support for GRETAP tunnels. (#34)
Maximilian Wilhelm [Tue, 24 Oct 2017 18:42:10 +0000 (20:42 +0200)]
addons: tunnel: Add support for GRETAP tunnels. (#34)

This commit adds support to configure and check gretap tunnels. An example
  configuration could look like this:

    iface tap0 inet tunnel
        mode gretap
        local 10.132.255.3
        endpoint 10.132.255.1
        ttl 64
        mtu 1400
        tunnel-physdev eth0
        #
        address 10.10.0.1/2

  ifup will happily configure the interface (which it does even without this
  patch) and ifquery now can successfully validate the configure interface:

    cr03.in.ffho.net:~# ifquery -c tap0
    iface tap0 inet tunnel                   [[ OK ]]
        tunnel-physdev eth0                  [[ OK ]]
        endpoint 10.132.255.1                [[ OK ]]
        local 10.132.255.3                   [[ OK ]]
        mode gretap                          [[ OK ]]
        ttl 64                               [[ OK ]]
        mtu 1400                             [[ OK ]]
        address 10.10.0.1/24                 [[ OK ]]

Signed-off-by: Maximilian Wilhelm <max@sdn.clinic>
5 years agoAddons/tunnel: fix typo in validvals (#31)
kokel [Tue, 3 Oct 2017 16:48:12 +0000 (18:48 +0200)]
Addons/tunnel: fix typo in validvals (#31)

5 years agoAdd support GRE/SIT tunnels. (#20)
Maximilian Wilhelm [Sat, 28 Jan 2017 22:54:43 +0000 (23:54 +0100)]
Add support GRE/SIT tunnels. (#20)

This commit adds support for configuring GRE/IPIP/SIT tunnel interfaces as know
from previous versions of ifupdown. Currently only configuration checks for GRE
and SIT tunnels are implemented.

A tunnel interface configuration could look like this:

auto gre42
iface gre42 inet tunnel
        mode     gre
        local    198.51.100.1
        endpoint 203.0.113.2
#
# optional tunnel attributes
        ttl      64
        mtu      1400
tunnel-physdev eth0
        #
        address  192.0.2.42/31
        address  2001:db8:d0c:23::42/64

auto he-ipv6
iface he-ipv6 inet tunnel
mode sit
endpoint 203.0.113.6
local    198.51.100.66
#
# optional tunnel attributes
ttl 255
mtu 1466
tunnel-physdev vrf_external
#
address 2001:db8:666::2/64

Signed-off-by: Maximilian Wilhelm <max@rfc2324.org>
5 years agobridge: vlan-aware: add new boolean policy "vlan_aware_bridge_address_support"
Julien Fortin [Mon, 18 Jun 2018 16:44:32 +0000 (18:44 +0200)]
bridge: vlan-aware: add new boolean policy "vlan_aware_bridge_address_support"

closes #58

In linux its possible to assign a vlan-aware bridge an ip address
For some use cases is it useful to restrict users from configuring
ips on bridges VA. This patch will let admins and distributions
decide if it is necessary to warn the user in such case.

The patch introduces a new 'address' policy:

 vlan_aware_bridge_address_support: yes|no|on|off|0|1 (default to yes)

[16:46:09] root:~ # cat /var/lib/ifupdown2/policy.d/address.json
{
    "address": {
"module_globals": {
    "enable_l3_iface_forwarding_checks": "yes"
},
"defaults": {
    "mtu": "1500",
    "ip-forward": "on",
    "ip6-forward": "on"
}
    }
}
[16:46:16] root:~ # ifquery -a
auto lo
iface lo inet loopback

auto eth0
iface eth0 inet dhcp

auto bridge
iface bridge
bridge-ports swp1
bridge-vlan-aware yes
address 10.10.10.10/32

[16:46:20] root:~ # ifup -a --syntax-check
[16:46:22] root:~ # echo $?
0
[16:46:33] root:~ # nano /var/lib/ifupdown2/policy.d/address.json
[16:46:47] root:~ # cat /var/lib/ifupdown2/policy.d/address.json
{
    "address": {
"module_globals": {
    "enable_l3_iface_forwarding_checks": "yes",
    "vlan_aware_bridge_address_support": "no"
},
"defaults": {
    "mtu": "1500",
    "ip-forward": "on",
    "ip6-forward": "on"
}
    }
}
[16:46:48] root:~ # ifup -a --syntax-check
warning: bridge: ignoring ip address. Assigning an IP address is not allowed on bridge vlan aware interfaces
[16:46:51] root:~ # echo $?
1
[16:46:52] root:~ #

Reviewed-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agoRevert "ifupdown2.conf: vlan_aware_bridge_address_support: allow ip on vlan-aware...
Julien Fortin [Mon, 25 Jun 2018 11:07:53 +0000 (13:07 +0200)]
Revert "ifupdown2.conf: vlan_aware_bridge_address_support: allow ip on vlan-aware bridge (closes #58)"

This reverts commit 3d06493205882c4485363bd63d5050c345c2fac9.

5 years agodebian: changelog: 1.2.0: new entry: metric on macvlan ip
Julien Fortin [Mon, 25 Jun 2018 10:29:43 +0000 (12:29 +0200)]
debian: changelog: 1.2.0: new entry: metric on macvlan ip

Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agoaddons: vrf: add support for 'link-down yes' on VRF slaves
Julien Fortin [Thu, 21 Jun 2018 09:36:10 +0000 (11:36 +0200)]
addons: vrf: add support for 'link-down yes' on VRF slaves

$ ifquery -a
auto lo
iface lo inet loopback

auto eth0
iface eth0 inet dhcp
vrf mgmt
link-down yes

auto mgmt
iface mgmt
vrf-table auto

$ ifup -a -d
...
...
debug: mgmt: pre-up : running module vrf
info: executing /usr/lib/vrf/vrf-helper create mgmt 1001
debug: mgmt: eth0: slave configured with link-down yes
info: mgmt: netlink: ip link set dev mgmt up
...
$ ip link show eth0
2: eth0: <BROADCAST,MULTICAST> mtu 1500 qdisc pfifo_fast master mgmt state DOWN mode DEFAULT group default qlen 1000
    link/ether 08:00:27:80:e2:97 brd ff:ff:ff:ff:ff:ff

Reviewed-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agoaddons: bridge: fix 'NoneType' object has no attribute 'keys' exception
Julien Fortin [Tue, 12 Jun 2018 17:22:34 +0000 (19:22 +0200)]
addons: bridge: fix 'NoneType' object has no attribute 'keys' exception

Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agoaddons: bridge: support multiple bridge-port configuration lines
Julien Fortin [Tue, 12 Jun 2018 15:50:22 +0000 (17:50 +0200)]
addons: bridge: support multiple bridge-port configuration lines

Reviewed-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Reviewed-by: Sam Tannous <stannous@cumulusnetworks.com>
Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agoifupdownmain: run up/down on manual interfaces, but ignore any errors. (closes #48)
Julien Fortin [Wed, 20 Jun 2018 10:07:08 +0000 (12:07 +0200)]
ifupdownmain: run up/down on manual interfaces, but ignore any errors. (closes #48)

ifupdown changed its original behavior on "manual" address method:
https://salsa.debian.org/debian/ifupdown/commit/12d333d619013914aae7deafe45fb6191ff2fb2c

ifupdown2 needs to change it's behavior too.

Reported-by: Alexandre Derumier <aderumier@odiso.com>
Reviewed-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Co-authored-by: Alexandre Derumier <aderumier@odiso.com>
Co-authored-by: Julien Fortin <julien@cumulusnetworks.com>
Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agodebian: changelog: update/refactor changelog 1.2.0 entry
Julien Fortin [Wed, 20 Jun 2018 09:58:27 +0000 (11:58 +0200)]
debian: changelog: update/refactor changelog 1.2.0 entry

Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agoifupdown2.conf: vlan_aware_bridge_address_support: allow ip on vlan-aware bridge...
Julien Fortin [Mon, 18 Jun 2018 16:44:32 +0000 (18:44 +0200)]
ifupdown2.conf: vlan_aware_bridge_address_support: allow ip on vlan-aware bridge (closes #58)

In linux its possible to assign an ip address to a vlan-aware bridge
For some use cases is it useful to restrict users from configuring ips on
bridges VA. This patch will let admins and distributions decide if it is
necessary to warn the user in such case.

The patch introduces a new configuration variable in:
    /etc/network/ifudpown2/ifupdown2.conf

vlan_aware_bridge_address_support: yes|no|on|off|0|1 (default to yes)

[8:30:41] root:~ # cat /etc/network/ifupdown2/ifupdown2.conf | grep "vlan_aware_bridge_address_support"
[8:30:43] root:~ # ifquery bridge
auto bridge
iface bridge
bridge-ports swp1
bridge-vlan-aware yes
address 10.10.10.10

[8:30:46] root:~ # ifup bridge --syntax-check
[8:30:52] root:~ # echo $?
0
[8:30:54] root:~ # echo "vlan_aware_bridge_address_support=no" >> /etc/network/ifupdown2/ifupdown2.conf
[8:31:11] root:~ # ifup bridge --syntax-check
warning: bridge: ignoring ip address. Assigning an IP address is not allowed on bridge vlan aware interfaces
[8:31:14] root:~ # echo $?
1
[8:31:17] root:~ #
[8:31:20] root:~ # ifup -a
[8:31:22] root:~ # echo $?
0
[8:31:25] root:~ # ifquery bridge -c
auto bridge
iface bridge                                                        [fail]
bridge-vlan-aware yes                                       [pass]
bridge-ports swp1                                           [pass]
address 10.10.10.10                                         [fail]

[8:31:29] root:~ # ifdown bridge && ifup bridge -v |& grep "bridge vlan aware interfaces"
info: bridge: ignoring ip address. Assigning an IP address is not allowed on bridge vlan aware interfaces
[8:31:57] root:~ #

Reviewed-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agodebian: changelog: 1.2.0: new entry for ipv6-addrgen attribute
Julien Fortin [Mon, 18 Jun 2018 17:10:10 +0000 (19:10 +0200)]
debian: changelog: 1.2.0: new entry for ipv6-addrgen attribute

Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agoaddons: addressvirtual: fix typo in address-virtual-ipv6-addrgen examples
Julien Fortin [Mon, 18 Jun 2018 17:28:32 +0000 (19:28 +0200)]
addons: addressvirtual: fix typo in address-virtual-ipv6-addrgen examples

typo: missing 'n' in the example field

Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agoaddons: addressvirtual: if system supports addr METRIC set skip route hack
Julien Fortin [Mon, 18 Jun 2018 17:24:12 +0000 (19:24 +0200)]
addons: addressvirtual: if system supports addr METRIC set skip route hack

Now that some system support ip addr METRIC sets we dont have to do this
"fix_connected_route" hack. The hack was previously introduced to make
sure the primary address was the first in the routing table. Some events
could cause some issues like having the macvlan address first in the
routing table. In that case the macvlan needs to be flapped. This shouldn't
happen when we are able to set the address metric

Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agoaddons: addressvirtual: new attribute: address-virtual-ipv6-addrgen [on|off]
Julien Fortin [Mon, 18 Jun 2018 14:51:51 +0000 (16:51 +0200)]
addons: addressvirtual: new attribute: address-virtual-ipv6-addrgen [on|off]

[14:53:46] root:~ # ifquery -a
auto lo
iface lo inet loopback

auto eth0
iface eth0 inet dhcp

auto vlan1903
iface vlan1903
alias LAB-CUST-VMS
vlan-id 1903
vlan-raw-device bridge
address 2a06:c01:1:1903::3/64
address 185.98.123.3/24
address-virtual 00:00:5e:00:01:a3 2a06:c01:1:1903::1/64 fe80::1/64 185.98.123.1/24
vrf public

auto public
iface public
vrf-table auto

auto bridge
iface bridge
bridge-ports swp1

[14:53:47] root:~ # ifup -a
[14:53:50] root:~ # ip addr show vlan1903-v0
46: vlan1903-v0@vlan1903: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue master public state UP group default
    link/ether 00:00:5e:00:01:a3 brd ff:ff:ff:ff:ff:ff
    inet 185.98.123.1/24 scope global vlan1903-v0
       valid_lft forever preferred_lft forever
    inet6 2a06:c01:1:1903::1/64 scope global
       valid_lft forever preferred_lft forever
    inet6 fe80::200:5eff:fe00:1a3/64 scope link
       valid_lft forever preferred_lft forever
    inet6 fe80::1/64 scope link
       valid_lft forever preferred_lft forever
[14:53:52] root:~ #
[14:53:54] root:~ #
[14:53:54] root:~ # nano /etc/network/interfaces
[14:53:57] root:~ # ifquery vlan1903
auto vlan1903
iface vlan1903
alias LAB-CUST-VMS
vlan-id 1903
vlan-raw-device bridge
address 2a06:c01:1:1903::3/64
address 185.98.123.3/24
address-virtual 00:00:5e:00:01:a3 2a06:c01:1:1903::1/64 fe80::1/64 185.98.123.1/24
address-virtual-ipv6-addrgen off
vrf public

[14:54:05] root:~ # ifdown -a -X eth0
[14:54:08] root:~ # ifup -a -v
...
...
info: executing /bin/ip -force -batch - [link set dev vlan1903-v0 master public
link set dev vlan1903-v0 addrgenmode none
link set dev vlan1903-v0 down
link set dev vlan1903-v0 address 00:00:5e:00:01:a3
link set dev vlan1903-v0 up
addr add 2a06:c01:1:1903::1/64 dev vlan1903-v0
addr add fe80::1/64 dev vlan1903-v0
addr add 185.98.123.1/24 dev vlan1903-v0
route del 2a06:c01:1:1903::/64 table 1001 dev vlan1903-v0
route del fe80::/64 table 1001 dev vlan1903-v0
route add 2a06:c01:1:1903::/64 table 1001 dev vlan1903-v0 proto kernel metric 9999
route add fe80::/64 table 1001 dev vlan1903-v0 proto kernel metric 9999
]
...
...
[14:54:14] root:~ # ip addr show vlan1903-v0
50: vlan1903-v0@vlan1903: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue master public state UP group default
    link/ether 00:00:5e:00:01:a3 brd ff:ff:ff:ff:ff:ff
    inet 185.98.123.1/24 scope global vlan1903-v0
       valid_lft forever preferred_lft forever
    inet6 2a06:c01:1:1903::1/64 scope global
       valid_lft forever preferred_lft forever
    inet6 fe80::1/64 scope link
       valid_lft forever preferred_lft forever
[14:54:16] root:~ #

Reviewed-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agoaddons: address: new attribute: ipv6-addrgen [on/off]
Julien Fortin [Mon, 18 Jun 2018 16:57:20 +0000 (18:57 +0200)]
addons: address: new attribute: ipv6-addrgen [on/off]

[14:49:15] root:~ # ifquery swp2
auto swp2
iface swp2

[14:49:18] root:~ # ip addr show swp2
4: swp2: <BROADCAST,MULTICAST> mtu 1500 qdisc pfifo_fast state DOWN group default qlen 1000
    link/ether 90:e2:ba:2c:b2:95 brd ff:ff:ff:ff:ff:ff
[14:49:20] root:~ # ifup swp2
[14:49:23] root:~ # ip addr show swp2
4: swp2: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP group default qlen 1000
    link/ether 90:e2:ba:2c:b2:95 brd ff:ff:ff:ff:ff:ff
    inet6 fe80::92e2:baff:fe2c:b295/64 scope link
       valid_lft forever preferred_lft forever
[14:49:25] root:~ #
[14:49:32] root:~ # nano /etc/network/interfaces
[14:49:34] root:~ # ifquery swp2
auto swp2
iface swp2
        ipv6-addrgen off

[14:49:41] root:~ # ifup -v swp2 |& grep addrgen
link set dev swp2 addrgenmode none
[14:49:57] root:~ # ip addr show swp2
4: swp2: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP group default qlen 1000
    link/ether 90:e2:ba:2c:b2:95 brd ff:ff:ff:ff:ff:ff
[14:50:01] root:~ #
[14:50:09] root:~ #
[14:50:09] root:~ # ifup -v swp2
info: executing /bin/ip -force -batch - [link set dev swp2 down
link set dev swp2 addrgenmode none
link set dev swp2 up
]
info: reading '/proc/sys/net/ipv4/conf/swp2/accept_local'
[14:50:13] root:~ #

Reviewed-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agobackport: "Add support for setting phys-dev for VXLAN interfaces."
Julien Fortin [Mon, 18 Jun 2018 12:19:14 +0000 (14:19 +0200)]
backport: "Add support for setting phys-dev for VXLAN interfaces."

backporting the following commit to master-next:

commit eb92e5efff776602081b8bbd2cc74462293c4b79
Author: Maximilian Wilhelm <max@rfc2324.org>
Date:   Thu Oct 6 19:22:06 2016 +0200

    Add support for setting phys-dev for VXLAN interfaces.

      Add interface configuration option »vxlan-physdev« to set »dev« attribute
            of VXLAN interfaces and a check for the running configuration.

Signed-off-by: Maximilian Wilhelm <max@rfc2324.org>
This backport also:
 - adds support for ifquery --running
 - uses the netlink cache
 - includes some pep8 fixes

Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
Signed-off-by: Maximilian Wilhelm <max@rfc2324.org>
Co-authored-by: Julien Fortin <julien@cumulusnetworks.com>
Co-authored-by: Maximilian Wilhelm <max@rfc2324.org>
5 years agoaddressvirtual: address: add default metric to ip4 and ip6 (if available)
Julien Fortin [Sat, 16 Jun 2018 17:56:57 +0000 (19:56 +0200)]
addressvirtual: address: add default metric to ip4 and ip6 (if available)

Reviewed-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Reviewed-by: David Ahern <dsa@cumulusnetworks.com>
Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agoaddons: addressvirtual: if device is VRF slave check vrf route table
Julien Fortin [Fri, 15 Jun 2018 15:59:19 +0000 (17:59 +0200)]
addons: addressvirtual: if device is VRF slave check vrf route table

auto bridge
iface bridge
      bridge-vlan-aware yes
      bridge-ports swp2

auto bridge.2
iface bridge.2
      address 10.254.1.2/24
      address 2a03:25e0:254:1::2/64
      address-virtual 00:00:5e:00:01:01 10.254.1.1/24 2a03:25e0:254:1::1/64 fe80::1/64
      vrf blue

auto blue
iface blue
      vrf-table auto

$ ifreload -a -v
...
info: executing /bin/ip route get 10.254.1.0/24 vrf blue
...
$

Reviewed-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agodebian: changelog: change version to 1.2.0
Julien Fortin [Fri, 15 Jun 2018 15:58:26 +0000 (17:58 +0200)]
debian: changelog: change version to 1.2.0

Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agonlmanager : nlpacket : IFLA_BRPORT_ARP_SUPPRESS : use 32 netlink value : (fixes #47)
Alexandre Derumier [Wed, 16 May 2018 00:16:42 +0000 (02:16 +0200)]
nlmanager : nlpacket : IFLA_BRPORT_ARP_SUPPRESS : use 32 netlink value : (fixes #47)

this has been upstreamed recently in linux kernel, with
IFLA_BRPORT_NEIGH_SUPPRESS, with 32 as netlink value.
https://www.spinics.net/lists/linux-ethernet-bridging/msg06910.html

Cumulus is using a temp 152 number in his own kernel.

This is needed for bgp evpn and anycast gateway.

auto vmbr3
iface vmbr3
        bridge_ports vxlan3
        bridge_stp off
        bridge_fd 0

auto vxlan3
iface vxlan3 inet manual
        vxlan-id 3
        vxlan-local-tunnelip 10.59.100.231
        bridge-learning off
        bridge-arp-nd-suppress on

info: reading '/sys/class/net/vmbr3/bridge/stp_state'
debug: vmbr3: evaluating port expr '['vxlan3']'
debug: _cache_get(['vxlan3', 'hwaddress']) : ['hwaddress']
debug: reading '/sys/class/net/vxlan3/address'
info: writing '1' to file /proc/sys/net/ipv6/conf/vxlan3/disable_ipv6
info: executing /bin/ip -force -batch - [link set dev vxlan3 master vmbr3
addr flush dev vxlan3
]
info: vmbr3: applying bridge port configuration: ['vxlan3']
info: vmbr3: vxlan3: set bridge-learning off
debug: (cache None)
info: vmbr3: vxlan3: set bridge-arp-nd-suppress on
debug: (cache None)
info: vmbr3: vxlan3: vxlan learning and bridge learning out of sync: set False
info: vxlan3: netlink: ip link set dev vxlan3: bridge slave attributes
debug: vxlan3: ifla_info_data {7: False}
debug: vxlan3: ifla_info_slave_data {8: False, 152: True}

5 years agoifupdown: ifupdownmain: create a copy of environment dictionary for addons scripts...
Alexandre Derumier [Mon, 14 May 2018 14:27:22 +0000 (16:27 +0200)]
ifupdown: ifupdownmain: create a copy of environment dictionary for addons scripts (fixes #49)

Today when ifupdown2 execute addons scripts we use the global environment
dictionary (os.environ) and not a copy of this dict. This corrupts the environment.

May 10 08:07:02 kvmformation1 networking[375279]: debug: vmbr101: pre-up :
 running script /etc/network/if-pre-up.d/openvswitch {'LANG': 'en_US.UTF-8',
 'ADDRFAM': '', 'IFACE': 'vmbr101', 'JOURNAL_STREAM': '9:29498964', 'SHLVL':
 '1', 'LOGICAL': 'vmbr101', 'PWD': '/', 'MODE': 'start', '**IF_TESTVARIABLE2**':
 'test', 'PHASE': 'pre-up', 'PATH': '/sbin:/bin', 'METHOD': '', '_':
 '/sbin/ifreload', 'INVOCATION_ID': '5ffcea837bc64759bd0c171b70e22cc2'}

May 10 08:07:02 kvmformation1 networking[375279]: debug: vmbr100: pre-up :
 running script /etc/network/if-pre-up.d/openvswitch {'LANG': 'en_US.UTF-8',
 'ADDRFAM': '', '**IF_OVS_TYPE**': 'OVSBridge', 'IFACE': 'vmbr100',
 'JOURNAL_STREAM': '9:29498964', 'SHLVL': '1', 'LOGICAL': 'vmbr100', 'PWD':
 '/', 'MODE': 'start', '**IF_TESTVARIABLE2**': 'test', 'PHASE': 'pre-up',
 'PATH': '/sbin:/bin', 'METHOD': '', '_': '/sbin/ifreload', 'INVOCATION_ID':
 '5ffcea837bc64759bd0c171b70e22cc2'}

May 10 08:07:02 kvmformation1 networking[375279]: debug: eno1: pre-up :
 running script /etc/network/if-pre-up.d/openvswitch {'LANG': 'en_US.UTF-8',
 'ADDRFAM': '', '**IF_OVS_TYPE**': 'OVSBridge', 'IFACE': 'eno1',
 'JOURNAL_STREAM': '9:29498964', 'SHLVL': '1', 'LOGICAL': 'eno1', 'PWD': '/',
 'MODE': 'start', '**IF_TESTVARIABLE2**': 'test', '**IF_TESTVARIABLE1**':
 'test', 'PHASE': 'pre-up', 'PATH': '/sbin:/bin', 'METHOD': '', '_':
 '/sbin/ifreload', 'INVOCATION_ID': '5ffcea837bc64759bd0c171b70e22cc2'}

May 10 08:07:02 kvmformation1 networking[375279]: debug: eno1.100: pre-up :
 running script /etc/network/if-pre-up.d/openvswitch {'LANG': 'en_US.UTF-8',
 'ADDRFAM': '', '**IF_OVS_TYPE**': 'OVSBridge', 'IFACE': 'eno1.100',
 'JOURNAL_STREAM': '9:29498964', 'SHLVL': '1', 'IF_NETMASK': '255.255.255.0',
 'IF_ADDRESS': '10.59.100.231', 'LOGICAL': 'eno1.100', 'IF_GATEWAY': '10.59.100.1',
 'PWD': '/', 'MODE': 'start', '**IF_TESTVARIABLE2**': 'test', 'IF_TESTVARIABLE1':
 'test', 'PHASE': 'pre-up', 'PATH': '/sbin:/bin', 'METHOD': '', '_':
 '/sbin/ifreload', 'INVOCATION_ID': '5ffcea837bc64759bd0c171b70e22cc2'}

5 years agorenamed: README -> README.rst
Julien Fortin [Tue, 12 Jun 2018 09:14:38 +0000 (11:14 +0200)]
renamed:    README -> README.rst

Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agoifupdown2 2.0.0 release
Julien Fortin [Tue, 12 Jun 2018 09:09:47 +0000 (11:09 +0200)]
ifupdown2 2.0.0 release

Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agoifupdown2 2.0.0 release
Julien Fortin [Thu, 13 Dec 2018 19:43:32 +0000 (11:43 -0800)]
ifupdown2 2.0.0 release

This is a major update coming all at once from master-next branch
master-next branch was started with --orphan option which is basically a new
branch without history.

The major changes are:
    - repackaging
    - cleanup the directory tree
    - rewritte setup.py to allow install from deb file or pypi (pip install)
    - add a Makefile to make things (like building a deb) easier
    - review all debian files

Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
5 years agoMerge pull request #80 from BarbarossaTM/tunnel-fixes-master
Julien Fortin [Tue, 30 Oct 2018 11:17:56 +0000 (12:17 +0100)]
Merge pull request #80 from BarbarossaTM/tunnel-fixes-master

Tunnel fixes master

5 years agoaddons: tunnel: Make sure tunnel modes are read correctly
Maximilian Wilhelm [Mon, 29 Oct 2018 19:35:30 +0000 (20:35 +0100)]
addons: tunnel: Make sure tunnel modes are read correctly

  Latest additions added a bunch of new tunnel modes but didn't add support
  to read in these modes which breaks 'ifquery' as it falsely marks the mode
  as 'fail'.

Signed-off-by: Maximilian Wilhelm <max@sdn.clinic>
5 years agoaddons: tunnel: Fix (re)creation of tunnelsof any kind.
Maximilian Wilhelm [Mon, 29 Oct 2018 19:31:17 +0000 (20:31 +0100)]
addons: tunnel: Fix (re)creation of tunnelsof any kind.

  Create all tunnels - except gretap - with 'ip tunnel', as this supports
  most tunnel modes; create gretap tunnels with 'ip link'.

  Rework the whole concept of tunnel updates and make sure a tunnel only is
  changed - recreated - IFF the configuration has changed. In previos code
  'tunnel change' was called on every _up() call. The 'tunnel change' part
  was removed completely as it doesn't work on many occations. So IFF the
  tunnel related interface configuration has changed, the tunnel is removed
  and recreated.

  fixes #78

Signed-off-by: Maximilian Wilhelm <max@sdn.clinic>
5 years agoMerge pull request #73 from carlanton/ethtool-typo-fix
Julien Fortin [Mon, 10 Sep 2018 11:07:21 +0000 (13:07 +0200)]
Merge pull request #73 from carlanton/ethtool-typo-fix

addons: ethtool: fix indentation error for link-fec attr handling

5 years agoFix indentation error in ethtool.py
Anton Lindström [Sun, 9 Sep 2018 17:28:31 +0000 (19:28 +0200)]
Fix indentation error in ethtool.py

6 years agoMerge pull request #46 from svenauhagen/feature/ppp
Julien Fortin [Fri, 13 Apr 2018 17:38:25 +0000 (19:38 +0200)]
Merge pull request #46 from svenauhagen/feature/ppp

ppp support closes #22

6 years agodependent device fix
Sven Auhagen [Fri, 13 Apr 2018 17:32:04 +0000 (19:32 +0200)]
dependent device fix

6 years agoppp load
Sven Auhagen [Sat, 7 Apr 2018 17:22:33 +0000 (19:22 +0200)]
ppp load

6 years agodo not load ppp if not installed
Sven Auhagen [Sat, 7 Apr 2018 17:21:04 +0000 (19:21 +0200)]
do not load ppp if not installed

6 years agoexclude ppp like dhcp
Sven Auhagen [Sat, 7 Apr 2018 16:07:30 +0000 (18:07 +0200)]
exclude ppp like dhcp

6 years agotypo
Sven Auhagen [Sat, 7 Apr 2018 15:35:04 +0000 (17:35 +0200)]
typo

6 years agoppp support
Sven Auhagen [Sat, 7 Apr 2018 15:29:51 +0000 (17:29 +0200)]
ppp support

6 years agoMerge pull request #45 from svenauhagen/feature/tunnels
Julien Fortin [Fri, 6 Apr 2018 04:45:00 +0000 (16:45 +1200)]
Merge pull request #45 from svenauhagen/feature/tunnels

tunnel changes

6 years agochache error on change
Sven Auhagen [Thu, 5 Apr 2018 05:32:42 +0000 (07:32 +0200)]
chache error on change

6 years agofix tunnel v4 to v6 change
Sven Auhagen [Wed, 4 Apr 2018 18:53:32 +0000 (20:53 +0200)]
fix tunnel v4 to v6 change

6 years agoname fix
Sven Auhagen [Wed, 4 Apr 2018 18:06:48 +0000 (20:06 +0200)]
name fix

6 years agotunnel changes
Sven Auhagen [Wed, 4 Apr 2018 17:49:34 +0000 (19:49 +0200)]
tunnel changes

6 years agoaddon/batctl: lookup batctl dynamically from PATH
skorpy [Sun, 25 Feb 2018 22:35:59 +0000 (23:35 +0100)]
addon/batctl: lookup batctl dynamically from PATH

Currently it is called from /usr/sbin/batctl what makes it impossible to use in case one runs a self compiled version for example

6 years agoaddons: vrf: fix vrf slave link kind (fixes #39)
Julien Fortin [Mon, 22 Jan 2018 11:09:07 +0000 (19:09 +0800)]
addons: vrf: fix vrf slave link kind (fixes #39)

$ cat /etc/network/interfaces
auto v0
iface v0
      link-type veth
      vrf blue

auto blue
iface blue
      vrf-table auto

$ ifreload -a
$ echo $?
0
$ ifquery -a -c
auto v0
iface v0                         [pass]
      link-type veth             [pass]
      vrf blue                   [pass]

auto blue
iface blue                       [pass]
      vrf-table 1001             [pass]
$ echo $?
0

Reported-by: Maximilian Wilhelm <max@rfc2324.org>
Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
6 years agoaddons: bridge: allow "bridge-ports: none" for bridges without initial ports. (#33)
Maximilian Wilhelm [Tue, 24 Oct 2017 18:58:10 +0000 (20:58 +0200)]
addons: bridge: allow "bridge-ports: none" for bridges without initial ports. (#33)

This simple patch allows the creation of bridges which should be set up
  without any ports, like a bridge for virtual machines on a hosting box.

  With this patch ifupdown2 get's a step closer to feature parity and
  compatiblity with ifupdown1.

Signed-off-by: Maximilian Wilhelm <max@sdn.clinic>
6 years agoaddons: tunnel: Add support for GRETAP tunnels. (#34)
Maximilian Wilhelm [Tue, 24 Oct 2017 18:42:10 +0000 (20:42 +0200)]
addons: tunnel: Add support for GRETAP tunnels. (#34)

This commit adds support to configure and check gretap tunnels. An example
  configuration could look like this:

    iface tap0 inet tunnel
        mode gretap
        local 10.132.255.3
        endpoint 10.132.255.1
        ttl 64
        mtu 1400
        tunnel-physdev eth0
        #
        address 10.10.0.1/2

  ifup will happily configure the interface (which it does even without this
  patch) and ifquery now can successfully validate the configure interface:

    cr03.in.ffho.net:~# ifquery -c tap0
    iface tap0 inet tunnel                   [[ OK ]]
        tunnel-physdev eth0                  [[ OK ]]
        endpoint 10.132.255.1                [[ OK ]]
        local 10.132.255.3                   [[ OK ]]
        mode gretap                          [[ OK ]]
        ttl 64                               [[ OK ]]
        mtu 1400                             [[ OK ]]
        address 10.10.0.1/24                 [[ OK ]]

Signed-off-by: Maximilian Wilhelm <max@sdn.clinic>
6 years agoaddons: batman_adv: Add support for more B.A.T.M.A.N. adv. attributes. (#35)
Maximilian Wilhelm [Tue, 24 Oct 2017 18:38:32 +0000 (20:38 +0200)]
addons: batman_adv: Add support for more B.A.T.M.A.N. adv. attributes. (#35)

* addons: batman_adv: Rework B.A.T.M.A.N. adv. attribute handling.

  This commit reworks the internal handling of B.A.T.M.A.N. adv. attributes
  within the plugin. The new approach on setting and checking attributes is
  more generic and allows adding more B.A.T.M.A.N. adv. which should be set
  as attributes of an B.A.T.M.A.N. adv. interface in a simple way.

  This commit does not introduce any changes visibile to the user.

Signed-off-by: Maximilian Wilhelm <max@sdn.clinic>
* addons: batman_adv: Add support for more B.A.T.M.A.N. adv. attributes.

  This commit adds supports for setting the following optional attributes:
   * gw-mode (one of { off, client, server })
   * multicast-mode (can be 'enabled' or 'disabled')
   * distributed-arp-table (cat be 'enabled' or 'disabled')

  Example config:

  pandora:~# ifquery -c bat-foo
  iface bat-foo                                         [pass]
      batman-ifaces dummy-bat                           [pass]
      batman-ifaces-ignore-regex                        [pass]
      batman-hop-penalty 7                              [pass]
      batman-multicast-mode enabled                     [pass]
      batman-distributed-arp-table enabled              [pass]
      batman-gw-mode client                             [pass]

Signed-off-by: Maximilian Wilhelm <max@sdn.clinic>
6 years agoAddons/tunnel: fix typo in validvals (#31)
kokel [Tue, 3 Oct 2017 16:48:12 +0000 (18:48 +0200)]
Addons/tunnel: fix typo in validvals (#31)

6 years agoaddons: address: Fix handling of 'pointopoint' attr. (#23)
Maximilian Wilhelm [Wed, 23 Aug 2017 21:11:57 +0000 (23:11 +0200)]
addons: address: Fix handling of 'pointopoint' attr. (#23)

Due to a simple logic bug the 'pointopoint' attribute was ignored when
  specifying and address as <ip/mask> and only considered when IP and mask
  where given seperately. This commit fixes this behaviour.

  When configured in ptp mode »ip addr« will show the IP address without a
  netmask which will make »ifquery -c« mark the IP as failed. The check has
  been fixed, too.

Signed-off-by: Maximilian Wilhelm <max@rfc2324.org>
6 years agosbin: ifupdown2: update ifupdown2 version number for --version option
Julien Fortin [Sun, 5 Mar 2017 17:21:35 +0000 (00:21 +0700)]
sbin: ifupdown2: update ifupdown2 version number for --version option

Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
6 years agosbin: start-networking: adjust allow-hotplug behavior to ifupdown
Julien Fortin [Thu, 23 Feb 2017 09:42:34 +0000 (16:42 +0700)]
sbin: start-networking: adjust allow-hotplug behavior to ifupdown

Ticket: Bug#855598: src:ifupdown2: allow-hotplug behaves differently, not UPing interfaces
Reviewed By: Roopa
Testing Done: mark an interface (ethX) as hotplug then reboot

Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
6 years agoAdd support GRE/SIT tunnels. (#20)
Maximilian Wilhelm [Sat, 28 Jan 2017 22:54:43 +0000 (23:54 +0100)]
Add support GRE/SIT tunnels. (#20)

This commit adds support for configuring GRE/IPIP/SIT tunnel interfaces as know
from previous versions of ifupdown. Currently only configuration checks for GRE
and SIT tunnels are implemented.

A tunnel interface configuration could look like this:

auto gre42
iface gre42 inet tunnel
        mode     gre
        local    198.51.100.1
        endpoint 203.0.113.2
#
# optional tunnel attributes
        ttl      64
        mtu      1400
tunnel-physdev eth0
        #
        address  192.0.2.42/31
        address  2001:db8:d0c:23::42/64

auto he-ipv6
iface he-ipv6 inet tunnel
mode sit
endpoint 203.0.113.6
local    198.51.100.66
#
# optional tunnel attributes
ttl 255
mtu 1466
tunnel-physdev vrf_external
#
address 2001:db8:666::2/64

Signed-off-by: Maximilian Wilhelm <max@rfc2324.org>
6 years agocloses: #810844: debian: control: Unlisted dependencies
Julien Fortin [Thu, 22 Dec 2016 13:01:52 +0000 (14:01 +0100)]
closes: #810844: debian: control: Unlisted dependencies

Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>