]> git.proxmox.com Git - mirror_iproute2.git/commit
testsuite: declare dependency between $(TESTS) and generate_nlmsg
authorLuca Boccassi <bluca@debian.org>
Sun, 16 Dec 2018 20:55:38 +0000 (20:55 +0000)
committerStephen Hemminger <sthemmin@microsoft.com>
Tue, 18 Dec 2018 17:58:10 +0000 (09:58 -0800)
commit61f9ade9fb1d9f208076e7a19473f0f740c7f78f
treea1b62a4c0a483a2c960f4cdafc18d6650b3d6cdf
parent0115d55e9f81a2e7d6ca8d5134084354898118b8
testsuite: declare dependency between $(TESTS) and generate_nlmsg

Parallel make from the top level directory fails since tests are at the
same time as generate_nlmsg:

$ make check -j4

...

cd testsuite && make && make alltests
echo "Entering iproute2" && cd iproute2 && make configure && cd ..;
Entering iproute2
make -C tools
Removing results dir ...
make[1]: ./tools/generate_nlmsg: Command not found
make[1]: ./tools/generate_nlmsg: Command not found
Makefile:64: recipe for target 'ip/netns/set_nsid_batch.t' failed
make[1]: *** [ip/netns/set_nsid_batch.t] Error 127
make[1]: ./tools/generate_nlmsg: Command not found
make[1]: *** Waiting for unfinished jobs....
Makefile:64: recipe for target 'ip/netns/set_nsid.t' failed
make[1]: *** [ip/netns/set_nsid.t] Error 127
Makefile:64: recipe for target 'ip/link/show_dev_wo_vf_rate.t' failed
make[1]: *** [ip/link/show_dev_wo_vf_rate.t] Error 127
    CC       generate_nlmsg
Makefile:123: recipe for target 'check' failed
make: *** [check] Error 2

Add an explicit dependency in testuite/Makefile's $(TESTS) rule so
that the tool correctly gets compiled before any test runs.

Fixes: 3537633dcf44 ("testsuite: Generate generate_nlmsg when needed")
Signed-off-by: Luca Boccassi <bluca@debian.org>
Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
Tested-by: Petr Vorel <petr.vorel@gmail.com>
Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
testsuite/Makefile