]> git.proxmox.com Git - mirror_iproute2.git/commit
devlink: fix memory leak in cmd_dev_flash()
authorAndrea Claudi <aclaudi@redhat.com>
Fri, 11 Dec 2020 18:53:02 +0000 (19:53 +0100)
committerStephen Hemminger <stephen@networkplumber.org>
Mon, 14 Dec 2020 17:23:24 +0000 (09:23 -0800)
commitec1346acbe9e5f0fe16242fc61b85d81f84ee592
treea3476f10d7ea526dce290381035d7d1797abfedf
parent309e6027e5013213ff6e5f8d4898b8756efdaf3b
devlink: fix memory leak in cmd_dev_flash()

nlg_ntf is dinamically allocated in mnlg_socket_open(), and is freed on
the out: return path. However, some error paths do not free it,
resulting in memory leak.

This commit fix this using mnlg_socket_close(), and reporting the
correct error number when required.

Fixes: 9b13cddfe268 ("devlink: implement flash status monitoring")
Signed-off-by: Andrea Claudi <aclaudi@redhat.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
devlink/devlink.c