]> git.proxmox.com Git - mirror_lxc.git/commit
Use AC_HEADER_MAJOR to detect major()/minor()/makedev()
authorSergei Trofimovich <siarheit@google.com>
Sat, 21 Jan 2017 11:57:13 +0000 (11:57 +0000)
committerSergei Trofimovich <siarheit@google.com>
Sat, 21 Jan 2017 11:57:13 +0000 (11:57 +0000)
commitaf6824fce9c9536fbcabef8d5547f6c486f55fdf
treea8e9e185ad6103733f510c10879ec86e3025ffd3
parentb7329cebaf60e03a773838fdf4b22e501c8f4d04
Use AC_HEADER_MAJOR to detect major()/minor()/makedev()

Before the change build failed on Gentoo as:

  bdev/lxclvm.c: In function 'lvm_detect':
  bdev/lxclvm.c:140:4: error: implicit declaration of function 'major' [-Werror=implicit-function-declaration]
    major(statbuf.st_rdev), minor(statbuf.st_rdev));
    ^~~~~
  bdev/lxclvm.c:140:28: error: implicit declaration of function 'minor' [-Werror=implicit-function-declaration]
    major(statbuf.st_rdev), minor(statbuf.st_rdev));
                            ^~~~~

glibc plans to remove <sys/sysmacros.h> from glibc's <sys/types.h>:
    https://sourceware.org/ml/libc-alpha/2015-11/msg00253.html

Gentoo already applied glibc patch to experimental glibc-2.24
to start preparingfor the change.

Autoconf has AC_HEADER_MAJOR to find out which header defines
reqiured macros:
    https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/Particular-Headers.html

This change should also increase portability across other libcs.

Bug: https://bugs.gentoo.org/604360
Signed-off-by: Sergei Trofimovich <siarheit@google.com>
configure.ac
src/lxc/bdev/lxclvm.c
src/lxc/conf.c
src/lxc/lxccontainer.c