]> git.proxmox.com Git - mirror_lxc.git/log
mirror_lxc.git
5 years agodoc: Add -a, --allowrunning arg to Korean lxc-copy(1)
2xsec [Fri, 23 Nov 2018 09:33:12 +0000 (18:33 +0900)]
doc: Add -a, --allowrunning arg to Korean lxc-copy(1)

Signed-off-by: 2xsec <dh48.jeong@samsung.com>
5 years agoMerge pull request #1943 from bhelm/master
Christian Brauner [Thu, 22 Nov 2018 22:51:47 +0000 (11:51 +1300)]
Merge pull request #1943 from bhelm/master

Added allowrunning command line option for snapshotting running containers

5 years agoMerge pull request #2732 from brauner/2018-11-21/remove_freezer_requirement
Stéphane Graber [Tue, 20 Nov 2018 17:27:16 +0000 (12:27 -0500)]
Merge pull request #2732 from brauner/2018-11-21/remove_freezer_requirement

cgfsng: remove freezer requirement

5 years agocgfsng: remove freezer requirement
Christian Brauner [Tue, 20 Nov 2018 17:06:43 +0000 (18:06 +0100)]
cgfsng: remove freezer requirement

The freezer controller has been made optional in all other codepaths so
don't require it.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agoMerge pull request #2731 from rst0git/master
Christian Brauner [Tue, 20 Nov 2018 02:19:22 +0000 (15:19 +1300)]
Merge pull request #2731 from rst0git/master

autotools: fix lxc-{create,copy} build

5 years agoautotools: fix lxc-{create,copy} build
Radostin Stoyanov [Tue, 20 Nov 2018 01:10:57 +0000 (01:10 +0000)]
autotools: fix lxc-{create,copy} build

After commit 2b670df lxc-create and lxc-copy fails with "undefined
symbol: get_fssize".

Closes #2730

Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
5 years agoMerge pull request #2728 from brauner/2018-11-19/keyctl_non_fatal
Stéphane Graber [Mon, 19 Nov 2018 02:43:42 +0000 (18:43 -0800)]
Merge pull request #2728 from brauner/2018-11-19/keyctl_non_fatal

utils: make keyring allocation failure non-fatal

5 years agoutils: make keyring allocation failure non-fatal
Christian Brauner [Mon, 19 Nov 2018 02:26:58 +0000 (03:26 +0100)]
utils: make keyring allocation failure non-fatal

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agoMerge pull request #2727 from Blub/2018-11-16/apparmor.ro-bind-remount-combinations
Christian Brauner [Fri, 16 Nov 2018 16:18:35 +0000 (08:18 -0800)]
Merge pull request #2727 from Blub/2018-11-16/apparmor.ro-bind-remount-combinations

apparmor: allow various remount,bind options

5 years agoapparmor: allow various remount,bind options
Wolfgang Bumiller [Thu, 15 Nov 2018 10:51:34 +0000 (11:51 +0100)]
apparmor: allow various remount,bind options

RW bind mounts need to be restricted for some paths in
order to avoid MAC restriction bypasses, but read-only bind
mounts shouldn't have that problem.

Additionally, combinations of 'nosuid', 'nodev' and
'noexec' flags shouldn't be a problem either and are
required with newer systemd versions, so let's allow those
as long as they're combined with 'ro,remount,bind'.

Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
5 years agoMerge pull request #2725 from tomponline/tp-lvcreate
Christian Brauner [Thu, 15 Nov 2018 18:48:17 +0000 (10:48 -0800)]
Merge pull request #2725 from tomponline/tp-lvcreate

Adds -qq flags to lvcreate commands

5 years agoAdds -qq flags to lvcreate commands to avoid answer 'no' to ant questions the LVM...
tomponline [Wed, 14 Nov 2018 13:55:18 +0000 (13:55 +0000)]
Adds -qq flags to lvcreate commands to avoid answer 'no' to ant questions the LVM subsystem asks to avoid hanging lxc-create command

Signed-off-by: tomponline <tomp@tomp.uk>
5 years agoMerge pull request #2723 from 2xsec/bugfix
Christian Brauner [Fri, 9 Nov 2018 10:22:19 +0000 (11:22 +0100)]
Merge pull request #2723 from 2xsec/bugfix

pam_cgfs: remove dependency & redundancy functions

5 years agoutils: add errno logs for exception case
2xsec [Fri, 9 Nov 2018 07:10:15 +0000 (16:10 +0900)]
utils: add errno logs for exception case

Signed-off-by: 2xsec <dh48.jeong@samsung.com>
5 years agoutils: fix coding styles
2xsec [Fri, 9 Nov 2018 07:08:37 +0000 (16:08 +0900)]
utils: fix coding styles

Signed-off-by: 2xsec <dh48.jeong@samsung.com>
5 years agopam_cgfs: remove dependency from cap & log
2xsec [Fri, 9 Nov 2018 07:06:33 +0000 (16:06 +0900)]
pam_cgfs: remove dependency from cap & log

Signed-off-by: 2xsec <dh48.jeong@samsung.com>
5 years agocgfs: remove redundancy utils
2xsec [Fri, 9 Nov 2018 05:10:46 +0000 (14:10 +0900)]
cgfs: remove redundancy utils

Signed-off-by: 2xsec <dh48.jeong@samsung.com>
5 years agopam_cgfs: remove redundancy file utils
2xsec [Fri, 9 Nov 2018 04:43:41 +0000 (13:43 +0900)]
pam_cgfs: remove redundancy file utils

Signed-off-by: 2xsec <dh48.jeong@samsung.com>
5 years agoMerge pull request #2722 from brauner/lxc/master
Stéphane Graber [Thu, 8 Nov 2018 19:35:09 +0000 (14:35 -0500)]
Merge pull request #2722 from brauner/lxc/master

conf: s/ty/tty/g

5 years agoconf: s/ty/tty/g
Christian Brauner [Thu, 8 Nov 2018 17:55:16 +0000 (18:55 +0100)]
conf: s/ty/tty/g

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agoMerge pull request #2720 from 2xsec/bugfix
Christian Brauner [Thu, 8 Nov 2018 10:41:38 +0000 (11:41 +0100)]
Merge pull request #2720 from 2xsec/bugfix

replace read & write syscalls with nointr functions

5 years agoMerge pull request #2721 from 2xsec/tizen
Christian Brauner [Thu, 8 Nov 2018 10:40:34 +0000 (11:40 +0100)]
Merge pull request #2721 from 2xsec/tizen

dlog: move match_dlog_fds()

5 years agodlog: move match_dlog_fds()
2xsec [Thu, 8 Nov 2018 10:18:41 +0000 (19:18 +0900)]
dlog: move match_dlog_fds()

Signed-off-by: 2xsec <dh48.jeong@samsung.com>
5 years agolog: replace write with lxc_write_nointr
2xsec [Thu, 8 Nov 2018 10:01:03 +0000 (19:01 +0900)]
log: replace write with lxc_write_nointr

Signed-off-by: 2xsec <dh48.jeong@samsung.com>
5 years agocaps: replace read with lxc_read_nointr
2xsec [Thu, 8 Nov 2018 10:00:19 +0000 (19:00 +0900)]
caps: replace read with lxc_read_nointr

Signed-off-by: 2xsec <dh48.jeong@samsung.com>
5 years agoMerge pull request #2719 from ssup2/master
Christian Brauner [Tue, 6 Nov 2018 18:10:25 +0000 (19:10 +0100)]
Merge pull request #2719 from ssup2/master

Fix spacing error in namespace.c

5 years agoFix spacing error in namespace.c
Jungsub [Tue, 6 Nov 2018 14:25:11 +0000 (14:25 +0000)]
Fix spacing error in namespace.c

Signed-off-by: Jungsub Shin supsup5642@tmax.co.kr
5 years agoMerge pull request #2717 from brauner/2018-11-02/fix_android
Stéphane Graber [Fri, 2 Nov 2018 22:40:26 +0000 (18:40 -0400)]
Merge pull request #2717 from brauner/2018-11-02/fix_android

include: correctly include macro.h

5 years agoinclude: correctly include macro.h
Christian Brauner [Fri, 2 Nov 2018 22:20:46 +0000 (23:20 +0100)]
include: correctly include macro.h

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agocoverity: move to separate branch
Christian Brauner [Fri, 2 Nov 2018 11:35:08 +0000 (12:35 +0100)]
coverity: move to separate branch

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agoMerge pull request #2715 from 2xsec/bugfix
Christian Brauner [Fri, 2 Nov 2018 10:57:20 +0000 (13:57 +0300)]
Merge pull request #2715 from 2xsec/bugfix

lxcmntent: coding rules

5 years agoMerge pull request #2716 from 2xsec/tizen
Christian Brauner [Fri, 2 Nov 2018 10:56:36 +0000 (13:56 +0300)]
Merge pull request #2716 from 2xsec/tizen

log: fix too wide or inconsistent non-owner permissions

5 years agolog: fix too wide or inconsistent non-owner permissions
2xsec [Fri, 2 Nov 2018 06:25:14 +0000 (15:25 +0900)]
log: fix too wide or inconsistent non-owner permissions

Signed-off-by: 2xsec <dh48.jeong@samsung.com>
5 years agostring_utils: coding rules
2xsec [Fri, 2 Nov 2018 06:17:50 +0000 (15:17 +0900)]
string_utils: coding rules

Signed-off-by: 2xsec <dh48.jeong@samsung.com>
5 years agolxcmntent: coding rules
2xsec [Fri, 2 Nov 2018 06:17:14 +0000 (15:17 +0900)]
lxcmntent: coding rules

Signed-off-by: 2xsec <dh48.jeong@samsung.com>
5 years agoMerge pull request #2714 from brauner/2018-11-01/remove_accidental_debug_statements
Stéphane Graber [Thu, 1 Nov 2018 23:58:16 +0000 (19:58 -0400)]
Merge pull request #2714 from brauner/2018-11-01/remove_accidental_debug_statements

confile: remove debug printf()s

5 years agoconfile: remove debug printf()s
Christian Brauner [Thu, 1 Nov 2018 21:50:18 +0000 (22:50 +0100)]
confile: remove debug printf()s

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agoMerge pull request #2713 from brauner/2018-10-30/mount_injection
Stéphane Graber [Thu, 1 Nov 2018 15:42:11 +0000 (11:42 -0400)]
Merge pull request #2713 from brauner/2018-10-30/mount_injection

conf: expand shmounts lxc.mount.auto option

5 years agolxccontainer: fix temporary path removal
Christian Brauner [Tue, 30 Oct 2018 22:48:14 +0000 (23:48 +0100)]
lxccontainer: fix temporary path removal

Needed-by: https://github.com/lxc/lxd/issues/5227
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agoconf: don't setup shared mountpoint for shmounts
Christian Brauner [Tue, 30 Oct 2018 14:38:50 +0000 (15:38 +0100)]
conf: don't setup shared mountpoint for shmounts

Leave it up to the caller for now until we have a clear way to do
this without causing double mounts etc.

Needed-by: https://github.com/lxc/lxd/issues/5227
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agoconf: expand shmounts lxc.mount.auto option
Christian Brauner [Tue, 30 Oct 2018 13:16:58 +0000 (14:16 +0100)]
conf: expand shmounts lxc.mount.auto option

Allow users to specify a path in the container they want to use.
This will help LXD.

Needed-by: https://github.com/lxc/lxd/issues/5227
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agoMerge pull request #2712 from jsoref/spelling
Christian Brauner [Thu, 1 Nov 2018 06:48:09 +0000 (07:48 +0100)]
Merge pull request #2712 from jsoref/spelling

Spelling

5 years agoMerge pull request #2710 from 2xsec/tizen
Christian Brauner [Wed, 31 Oct 2018 13:32:53 +0000 (14:32 +0100)]
Merge pull request #2710 from 2xsec/tizen

dlog: inherit dlog fds

5 years agoMerge pull request #2709 from 2xsec/bugfix
Christian Brauner [Tue, 30 Oct 2018 14:42:21 +0000 (15:42 +0100)]
Merge pull request #2709 from 2xsec/bugfix

storage_utils: add error handling

5 years agospelling: without
Josh Soref [Tue, 30 Oct 2018 08:26:30 +0000 (08:26 +0000)]
spelling: without

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: userns
Josh Soref [Tue, 30 Oct 2018 08:19:23 +0000 (08:19 +0000)]
spelling: userns

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: unsigned
Josh Soref [Tue, 30 Oct 2018 08:24:51 +0000 (08:24 +0000)]
spelling: unsigned

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: timeout
Josh Soref [Tue, 30 Oct 2018 08:14:58 +0000 (08:14 +0000)]
spelling: timeout

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: syscall
Josh Soref [Tue, 30 Oct 2018 08:12:17 +0000 (08:12 +0000)]
spelling: syscall

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: successfully
Josh Soref [Tue, 30 Oct 2018 08:12:07 +0000 (08:12 +0000)]
spelling: successfully

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: subtracting
Josh Soref [Tue, 30 Oct 2018 08:11:56 +0000 (08:11 +0000)]
spelling: subtracting

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: specify
Josh Soref [Tue, 30 Oct 2018 08:09:44 +0000 (08:09 +0000)]
spelling: specify

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: specified
Josh Soref [Tue, 30 Oct 2018 08:09:37 +0000 (08:09 +0000)]
spelling: specified

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: snapshotting
Josh Soref [Tue, 30 Oct 2018 08:09:19 +0000 (08:09 +0000)]
spelling: snapshotting

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: securityfs
Josh Soref [Tue, 30 Oct 2018 08:03:58 +0000 (08:03 +0000)]
spelling: securityfs

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: root
Josh Soref [Tue, 30 Oct 2018 07:59:43 +0000 (07:59 +0000)]
spelling: root

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: returns
Josh Soref [Tue, 30 Oct 2018 08:02:42 +0000 (08:02 +0000)]
spelling: returns

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: potentially
Josh Soref [Tue, 30 Oct 2018 07:56:15 +0000 (07:56 +0000)]
spelling: potentially

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: portion
Josh Soref [Tue, 30 Oct 2018 07:48:55 +0000 (07:48 +0000)]
spelling: portion

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: pertains
Josh Soref [Tue, 30 Oct 2018 07:47:48 +0000 (07:47 +0000)]
spelling: pertains

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: perhaps
Josh Soref [Tue, 30 Oct 2018 07:47:17 +0000 (07:47 +0000)]
spelling: perhaps

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: passphrase
Josh Soref [Tue, 30 Oct 2018 07:45:15 +0000 (07:45 +0000)]
spelling: passphrase

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: override
Josh Soref [Tue, 30 Oct 2018 07:44:56 +0000 (07:44 +0000)]
spelling: override

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: overridden
Josh Soref [Tue, 30 Oct 2018 07:37:31 +0000 (07:37 +0000)]
spelling: overridden

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: overlayfs
Josh Soref [Tue, 30 Oct 2018 07:37:13 +0000 (07:37 +0000)]
spelling: overlayfs

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: output
Josh Soref [Tue, 30 Oct 2018 07:36:14 +0000 (07:36 +0000)]
spelling: output

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: otherwise
Josh Soref [Tue, 30 Oct 2018 07:35:39 +0000 (07:35 +0000)]
spelling: otherwise

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: namespace
Josh Soref [Tue, 30 Oct 2018 07:26:07 +0000 (07:26 +0000)]
spelling: namespace

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: loglevel
Josh Soref [Tue, 30 Oct 2018 07:18:45 +0000 (07:18 +0000)]
spelling: loglevel

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: libraries
Josh Soref [Tue, 30 Oct 2018 07:18:08 +0000 (07:18 +0000)]
spelling: libraries

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: keepdata
Josh Soref [Tue, 30 Oct 2018 07:17:22 +0000 (07:17 +0000)]
spelling: keepdata

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: javascript
Josh Soref [Tue, 30 Oct 2018 07:16:39 +0000 (07:16 +0000)]
spelling: javascript

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: initialize
Josh Soref [Tue, 30 Oct 2018 07:13:17 +0000 (07:13 +0000)]
spelling: initialize

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: inherited
Josh Soref [Tue, 30 Oct 2018 07:12:26 +0000 (07:12 +0000)]
spelling: inherited

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: indefinitely
Josh Soref [Tue, 30 Oct 2018 07:12:08 +0000 (07:12 +0000)]
spelling: indefinitely

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: implementations
Josh Soref [Tue, 30 Oct 2018 07:11:52 +0000 (07:11 +0000)]
spelling: implementations

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: ifindices
Josh Soref [Tue, 30 Oct 2018 07:11:19 +0000 (07:11 +0000)]
spelling: ifindices

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: hoops
Josh Soref [Tue, 30 Oct 2018 07:09:02 +0000 (07:09 +0000)]
spelling: hoops

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: hierarchy
Josh Soref [Tue, 30 Oct 2018 07:08:31 +0000 (07:08 +0000)]
spelling: hierarchy

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: github
Josh Soref [Tue, 30 Oct 2018 17:13:36 +0000 (13:13 -0400)]
spelling: github

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: feature
Josh Soref [Tue, 30 Oct 2018 07:01:50 +0000 (07:01 +0000)]
spelling: feature

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: explicitly
Josh Soref [Tue, 30 Oct 2018 07:01:26 +0000 (07:01 +0000)]
spelling: explicitly

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: exiting
Josh Soref [Tue, 30 Oct 2018 07:01:12 +0000 (07:01 +0000)]
spelling: exiting

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: device
Josh Soref [Tue, 30 Oct 2018 07:00:01 +0000 (07:00 +0000)]
spelling: device

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: describing
Josh Soref [Tue, 30 Oct 2018 06:59:37 +0000 (06:59 +0000)]
spelling: describing

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: could
Josh Soref [Tue, 30 Oct 2018 06:54:56 +0000 (06:54 +0000)]
spelling: could

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: convenience
Josh Soref [Tue, 30 Oct 2018 06:55:05 +0000 (06:55 +0000)]
spelling: convenience

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: control
Josh Soref [Tue, 30 Oct 2018 06:54:21 +0000 (06:54 +0000)]
spelling: control

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: container
Josh Soref [Tue, 30 Oct 2018 06:53:11 +0000 (06:53 +0000)]
spelling: container

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: constant
Josh Soref [Tue, 30 Oct 2018 06:54:44 +0000 (06:54 +0000)]
spelling: constant

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: configuration
Josh Soref [Tue, 30 Oct 2018 06:52:44 +0000 (06:52 +0000)]
spelling: configuration

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: committer
Josh Soref [Tue, 30 Oct 2018 06:52:23 +0000 (06:52 +0000)]
spelling: committer

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: command
Josh Soref [Tue, 30 Oct 2018 06:52:09 +0000 (06:52 +0000)]
spelling: command

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: comma
Josh Soref [Tue, 30 Oct 2018 06:51:58 +0000 (06:51 +0000)]
spelling: comma

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: checkpoint
Josh Soref [Tue, 30 Oct 2018 06:50:25 +0000 (06:50 +0000)]
spelling: checkpoint

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: character
Josh Soref [Tue, 30 Oct 2018 06:50:12 +0000 (06:50 +0000)]
spelling: character

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: capabilities
Josh Soref [Tue, 30 Oct 2018 06:49:52 +0000 (06:49 +0000)]
spelling: capabilities

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: backingstorage
Josh Soref [Tue, 30 Oct 2018 06:49:12 +0000 (06:49 +0000)]
spelling: backingstorage

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: asynchronous
Josh Soref [Tue, 30 Oct 2018 06:48:09 +0000 (06:48 +0000)]
spelling: asynchronous

Signed-off-by: Josh Soref <jsoref@gmail.com>
5 years agospelling: array
Josh Soref [Tue, 30 Oct 2018 06:47:57 +0000 (06:47 +0000)]
spelling: array

Signed-off-by: Josh Soref <jsoref@gmail.com>