autotools: remove --enable-deprecated

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tree-wide: remove python3 bindings

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tree-wide: remove lua bindings

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tree-wide: cleanup

- remove legacy binaries
- conditionalize creation of docs and tests for the command line tools and the
  shared library helper commands

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

autotools: add --{enable,disable}-{commands,tools}

This allows users to only compile the shared libray without having to compile
any of the command line tools or command helpers for the shared library.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #2193 from brauner/2018-02-27/naming_tweaks

tree-wide: introduce consistent and agnostic naming for ptys, ttys, and consoles

terminal: lxc_terminal_write_log_file()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

terminal: lxc_terminal_rotate_log_file()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: s/peerpty/proxy/

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tree-wide: console.<c,h> -> terminal.<c,h>

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

console: struct lxc_terminal_state

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

console: s/tty_info/ttys/g

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

console: s/pty_info/tty/g

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

console: move struct lxc_terminal{_info}

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tree-wide: struct lxc_terminal_info

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tree-wide: s/struct lxc_pty/lxc_terminal/g

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

console: lxc_terminal_map_ids()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

console: lxc_terminal_conf_free()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

console: lxc_terminal_init()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

console: lxc_terminal_info_init()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

console: lxc_terminal_create()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

console: lxc_terminal_setup()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

console: s/console/terminal/g

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

console: lxc_terminal_getfd()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

console: lxc_terminal_master_cb()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

console: lxc_terminal_stdin_cb()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

console: lxc_terminal_set_stdfds()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

console: lxc_terminal_create()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

console: lxc_terminal_create_log_file()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

console: lxc_terminal_create_ringbuf()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

console: lxc_terminal_delete()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

console: lxc_terminal_init()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

console: lxc_terminal_write_ringbuffer()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

console: lxc_terminal_peer_default()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

console: lxc_terminal_free()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

console: lxc_terminal_allocate()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

console: lxc_terminal_peer_proxy_alloc()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

console: lxc_terminal_peer_proxy_free()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

console: lxc_terminal_mainloop_add()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

console: lxc_terminal_mainloop_add_peer()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

console: lxc_terminal_io_cb()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

console: lxc_terminal_signal_fini()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

console: lxc_terminal_signal_init()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

console: lxc_terminal_signalfd_cb()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

commands: lxc_cmd_terimal_winch()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

console: lxc_terminal_sigwinch()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

console: lxc_terminal_winch()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

console: lxc_terminal_winsz()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tree-wide: s/struct lxc_console/struct lxc_pty/g

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

cgfsng: non-functional changes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #2167 from brauner/2018-02-15/simplify_console_logging

console: simplify console logging

Merge pull request #2194 from hallyn/2018-02-27/lxcinit-umountdev

lxc_init: don't mount filesystems

lxc_init: don't mount filesystems

We have an extensive set of container config options to do this
for us, and doing this unconditionally breaks several use cases.
For instance, if we want to bind mount a /dev/shm using the
container configuration, then lxc-execute, then lxc-init will
rudely unmount the /dev/shm and remount it as a private tmpfs.

Signed-off-by: Serge Hallyn <shallyn@cisco.com>

console: always dump log file

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

console: dump ringbuffer to disk on container exit

The console ringbuffer will be dumped to disk if the console log file is not
rotated and it's size is not unlimited. In the former two cases we will have
all data from the ringbuffer available anyway.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

confile: remove lxc.console.buffer.logfile

All of its functionality is now covered over by lxc.console.logfile.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

confile: add lxc.console.size

lxc.console.size regulates the size of the console log file. This is intended
to replace lxc.console.buffer.logfile. The current semantics are:

- if lxc.console.size is not set:
  - no limit is placed on the size of the log file
- if lxc.console.size is set:
  - if lxc.console.rotate is set and the next write would exceed the limit:
    - write as much as possible into the old log file
    - rotate the log file
    - write as much as posible into the new log file
    - discard remaining bytes (scenario shouldn't be possible in normal
      circumstances)
  - if lxc.console.rotate is not set and the next write would exceed the limit:
    - keep overwriting the current log file

To make the log file a mirror of the in-memory ringbuffer simply set:
lxc.console.buffer.size == lxc.console.size.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

libpam: Drop mention to non-existing macro.h

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

Merge pull request #2192 from brauner/2018-02-26/enable_pam_flag

configure: add --enable-pam

Merge pull request #2190 from brauner/2018-02-16/lxc_local_template

templates: add lxc-local template

configure: add --enable-pam

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

templates: add lxc-local template

Closes #2184.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxc-oci: remove executable bit

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "Revert "pam: create writable cgroups for unpriv users""

This reverts commit 79cf25e826509e61cdda4c47d5aeb0e222439970.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #2191 from brauner/2018-02-16/fix_snapshot_segfault

lxc-snapshot: fix segfault

Merge pull request #2189 from brauner/2018-02-16/remove_needless_locking

commands: remove mutex from state client list

Merge pull request #2188 from brauner/2018-02-16/coding_style

CODING_STYLE: add section about _exit()

lxc-snapshot: fix segfault

https://bugs.launchpad.net/ubuntu/+source/lxc/+bug/1751780

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

parse: error out on invalid config key

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

commands: remove mutex from state client list

I was thinking about the locking here yesterday and it dawned on me that we
actually don't need this at all:
- possible contention between traversing list to send states to state clients
  and adding new state clients to the list:
  It is the command handler that adds new state clients to the state client
  list. The command handler and the code that actually sends out the container
  states run in the same process so there's not contention and thus no locking
  needed.
- adding state clients to the list from multiple threads:
  The command handler itself is single-threaded so only one thread's request can
  be served at the same time so no locking is needed.
- sending out the state to state clients via the command handler itself:
  The state client also adds and removes state clients from the state client
  list so there's no locking needed.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

CODING_STYLE: add section about _exit()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #2187 from itoffshore/alpine

fix download template for /tmp as tmpfs or noexec

fix download template for /tmp as tmpfs or noexec

* prepend $LXC_PATH to $DOWNLOAD_TEMP on systems with /tmp mounted
  securely as a small tmpfs / noexec

* gpg_setup() creates $DOWNLOAD_TEMP so remove superflous mkdir

* fixes https://github.com/lxc/lxc/issues/516

Signed-off-by: Stuart Cardall <developer@it-offshore.co.uk>

Merge pull request #2186 from brauner/2018-02-22/make_confile_reading_thread_safe

tree-wide: thread-safety improvements

cgfsng: fix get_hierarchy() for unified hierarchy

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

criu: du_dump()

thread-safety: s/exit()/_exit()/g

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

criu: do_restore()

thread-safety: s/exit()/_exit()/g

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

criu: criu_version_ok()

thread-safety: s/exit()/_exit()/g

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

criu: __criu_check_feature()

thread-safety: s/exit()/_exit()/g

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxccontainer: create_container_dir()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxccontainer: do_create_container_dir()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxccontainer: lxcapi_startl()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxccontainer: lxcapi_start()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxccontainer: free_init_cmd()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxccontainer: split_init_cmd()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxccontainer: push_arg()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxccontainer: am_single_threaded()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxccontainer: do_lxcapi_wait()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxccontainer: do_lxcapi_want_close_all_fds()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxccontainer: do_lxcapi_want_daemonize()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxccontainer: do_lxcapi_load_config()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxccontainer: load_config_locked()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxccontainer: lxcapi_console()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxccontainer: do_lxcapi_console_getfd()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxccontainer: do_lxcapi_unfreeze()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxccontainer: do_lxcapi_freeze()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxccontainer: do_lxcapi_is_running()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxccontainer: is_stopped()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxccontainer: do_lxcapi_state()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxccontainer: do_lxcapi_is_defined()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>