]> git.proxmox.com Git - mirror_lxcfs.git/blobdiff - bindings.c
bindings: increase reserved buffer size a little
[mirror_lxcfs.git] / bindings.c
index 9fbabb6a947403f3b594df2a7e63b99d7273379b..63870126f5847b1d0cef82c3262d7d87437a0e02 100644 (file)
@@ -72,8 +72,8 @@ struct file_info {
        int cached;
 };
 
-/* reserve buffer size, for cpuall in /proc/stat */
-#define BUF_RESERVE_SIZE 256
+/* Reserve buffer size to account for file size changes. */
+#define BUF_RESERVE_SIZE 512
 
 /*
  * A table caching which pid is init for a pid namespace.
@@ -863,11 +863,11 @@ bool cgfs_get_value(const char *controller, const char *cgroup, const char *file
        fnam = alloca(len);
        ret = snprintf(fnam, len, "%s%s/%s", *cgroup == '/' ? "." : "", cgroup, file);
        if (ret < 0 || (size_t)ret >= len)
-               return NULL;
+               return false;
 
        fd = openat(cfd, fnam, O_RDONLY);
        if (fd < 0)
-               return NULL;
+               return false;
 
        *value = slurp_file(fnam, fd);
        return *value != NULL;
@@ -2908,7 +2908,7 @@ int cg_rmdir(const char *path)
        if (initpid <= 0)
                initpid = fc->pid;
        if (!caller_is_in_ancestor(initpid, controller, cgroup, &next)) {
-               if (!last || strcmp(next, last) == 0)
+               if (!last || (next && (strcmp(next, last) == 0)))
                        ret = -EBUSY;
                else
                        ret = -ENOENT;
@@ -2953,19 +2953,19 @@ static void parse_memstat(char *memstat, unsigned long *cached,
 
        while (*memstat) {
                if (startswith(memstat, "cache")) {
-                       sscanf(memstat + 11, "%lu", cached);
+                       sscanf(memstat + 5, "%lu", cached);
                        *cached /= 1024;
                } else if (startswith(memstat, "active_anon")) {
                        sscanf(memstat + 11, "%lu", active_anon);
                        *active_anon /= 1024;
                } else if (startswith(memstat, "inactive_anon")) {
-                       sscanf(memstat + 11, "%lu", inactive_anon);
+                       sscanf(memstat + 13, "%lu", inactive_anon);
                        *inactive_anon /= 1024;
                } else if (startswith(memstat, "active_file")) {
                        sscanf(memstat + 11, "%lu", active_file);
                        *active_file /= 1024;
                } else if (startswith(memstat, "inactive_file")) {
-                       sscanf(memstat + 11, "%lu", inactive_file);
+                       sscanf(memstat + 13, "%lu", inactive_file);
                        *inactive_file /= 1024;
                } else if (startswith(memstat, "unevictable")) {
                        sscanf(memstat + 11, "%lu", unevictable);
@@ -3046,12 +3046,12 @@ static int read_file(const char *path, char *buf, size_t size,
  * FUSE ops for /proc
  */
 
-static unsigned long get_memlimit(const char *cgroup)
+static unsigned long get_memlimit(const char *cgroup, const char *file)
 {
        char *memlimit_str = NULL;
        unsigned long memlimit = -1;
 
-       if (cgfs_get_value("memory", cgroup, "memory.limit_in_bytes", &memlimit_str))
+       if (cgfs_get_value("memory", cgroup, file, &memlimit_str))
                memlimit = strtoul(memlimit_str, NULL, 10);
 
        free(memlimit_str);
@@ -3059,16 +3059,16 @@ static unsigned long get_memlimit(const char *cgroup)
        return memlimit;
 }
 
-static unsigned long get_min_memlimit(const char *cgroup)
+static unsigned long get_min_memlimit(const char *cgroup, const char *file)
 {
        char *copy = strdupa(cgroup);
        unsigned long memlimit = 0, retlimit;
 
-       retlimit = get_memlimit(copy);
+       retlimit = get_memlimit(copy, file);
 
        while (strcmp(copy, "/") != 0) {
                copy = dirname(copy);
-               memlimit = get_memlimit(copy);
+               memlimit = get_memlimit(copy, file);
                if (memlimit != -1 && memlimit < retlimit)
                        retlimit = memlimit;
        };
@@ -3083,11 +3083,11 @@ static int proc_meminfo_read(char *buf, size_t size, off_t offset,
        struct file_info *d = (struct file_info *)fi->fh;
        char *cg;
        char *memusage_str = NULL, *memstat_str = NULL,
-               *memswlimit_str = NULL, *memswusage_str = NULL,
-               *memswlimit_default_str = NULL, *memswusage_default_str = NULL;
+               *memswlimit_str = NULL, *memswusage_str = NULL;
        unsigned long memlimit = 0, memusage = 0, memswlimit = 0, memswusage = 0,
                cached = 0, hosttotal = 0, active_anon = 0, inactive_anon = 0,
-               active_file = 0, inactive_file = 0, unevictable = 0;
+               active_file = 0, inactive_file = 0, unevictable = 0,
+               hostswtotal = 0;
        char *line = NULL;
        size_t linelen = 0, total_len = 0, rv = 0;
        char *cache = d->buf;
@@ -3113,7 +3113,7 @@ static int proc_meminfo_read(char *buf, size_t size, off_t offset,
                return read_file("/proc/meminfo", buf, size, d);
        prune_init_slice(cg);
 
-       memlimit = get_min_memlimit(cg);
+       memlimit = get_min_memlimit(cg, "memory.limit_in_bytes");
        if (!cgfs_get_value("memory", cg, "memory.usage_in_bytes", &memusage_str))
                goto err;
        if (!cgfs_get_value("memory", cg, "memory.stat", &memstat_str))
@@ -3124,20 +3124,9 @@ static int proc_meminfo_read(char *buf, size_t size, off_t offset,
        if(cgfs_get_value("memory", cg, "memory.memsw.limit_in_bytes", &memswlimit_str) &&
                cgfs_get_value("memory", cg, "memory.memsw.usage_in_bytes", &memswusage_str))
        {
-               /* If swapaccounting is turned on, then default value is assumed to be that of cgroup / */
-               if (!cgfs_get_value("memory", "/", "memory.memsw.limit_in_bytes", &memswlimit_default_str))
-                       goto err;
-               if (!cgfs_get_value("memory", "/", "memory.memsw.usage_in_bytes", &memswusage_default_str))
-                       goto err;
-
-               memswlimit = strtoul(memswlimit_str, NULL, 10);
+               memswlimit = get_min_memlimit(cg, "memory.memsw.limit_in_bytes");
                memswusage = strtoul(memswusage_str, NULL, 10);
 
-               if (!strcmp(memswlimit_str, memswlimit_default_str))
-                       memswlimit = 0;
-               if (!strcmp(memswusage_str, memswusage_default_str))
-                       memswusage = 0;
-
                memswlimit = memswlimit / 1024;
                memswusage = memswusage / 1024;
        }
@@ -3160,7 +3149,7 @@ static int proc_meminfo_read(char *buf, size_t size, off_t offset,
 
                memset(lbuf, 0, 100);
                if (startswith(line, "MemTotal:")) {
-                       sscanf(line+14, "%lu", &hosttotal);
+                       sscanf(line+sizeof("MemTotal:")-1, "%lu", &hosttotal);
                        if (hosttotal < memlimit)
                                memlimit = hosttotal;
                        snprintf(lbuf, 100, "MemTotal:       %8lu kB\n", memlimit);
@@ -3172,6 +3161,9 @@ static int proc_meminfo_read(char *buf, size_t size, off_t offset,
                        snprintf(lbuf, 100, "MemAvailable:   %8lu kB\n", memlimit - memusage);
                        printme = lbuf;
                } else if (startswith(line, "SwapTotal:") && memswlimit > 0) {
+                       sscanf(line+sizeof("SwapTotal:")-1, "%lu", &hostswtotal);
+                       if (hostswtotal < memswlimit - memlimit)
+                               memswlimit = hostswtotal + memlimit;
                        snprintf(lbuf, 100, "SwapTotal:      %8lu kB\n", memswlimit - memlimit);
                        printme = lbuf;
                } else if (startswith(line, "SwapFree:") && memswlimit > 0 && memswusage > 0) {
@@ -3257,8 +3249,6 @@ err:
        free(memswlimit_str);
        free(memswusage_str);
        free(memstat_str);
-       free(memswlimit_default_str);
-       free(memswusage_default_str);
        return rv;
 }
 
@@ -3464,6 +3454,28 @@ err:
        return rv;
 }
 
+static long int getreaperctime(pid_t pid)
+{
+       char fnam[100];
+       struct stat sb;
+       int ret;
+       pid_t qpid;
+
+       qpid = lookup_initpid_in_store(pid);
+       if (qpid <= 0)
+               return 0;
+
+       ret = snprintf(fnam, 100, "/proc/%d", qpid);
+       if (ret < 0 || ret >= 100)
+               return 0;
+
+       if (lstat(fnam, &sb) < 0)
+               return 0;
+
+       return sb.st_ctime;
+}
+
+#define CPUALL_MAX_SIZE (BUF_RESERVE_SIZE / 2)
 static int proc_stat_read(char *buf, size_t size, off_t offset,
                struct fuse_file_info *fi)
 {
@@ -3474,10 +3486,9 @@ static int proc_stat_read(char *buf, size_t size, off_t offset,
        char *line = NULL;
        size_t linelen = 0, total_len = 0, rv = 0;
        int curcpu = -1; /* cpu numbering starts at 0 */
-       unsigned long user = 0, nice = 0, system = 0, idle = 0, iowait = 0, irq = 0, softirq = 0, steal = 0, guest = 0;
+       unsigned long user = 0, nice = 0, system = 0, idle = 0, iowait = 0, irq = 0, softirq = 0, steal = 0, guest = 0, guest_nice = 0;
        unsigned long user_sum = 0, nice_sum = 0, system_sum = 0, idle_sum = 0, iowait_sum = 0,
-                                       irq_sum = 0, softirq_sum = 0, steal_sum = 0, guest_sum = 0;
-#define CPUALL_MAX_SIZE BUF_RESERVE_SIZE
+                                       irq_sum = 0, softirq_sum = 0, steal_sum = 0, guest_sum = 0, guest_nice_sum = 0;
        char cpuall[CPUALL_MAX_SIZE];
        /* reserve for cpu all */
        char *cache = d->buf + CPUALL_MAX_SIZE;
@@ -3527,7 +3538,10 @@ static int proc_stat_read(char *buf, size_t size, off_t offset,
                        continue;
                if (sscanf(line, "cpu%9[^ ]", cpu_char) != 1) {
                        /* not a ^cpuN line containing a number N, just print it */
-                       l = snprintf(cache, cache_size, "%s", line);
+                       if (strncmp(line, "btime", 5) == 0)
+                               l = snprintf(cache, cache_size, "btime %ld\n", getreaperctime(fc->pid));
+                       else
+                               l = snprintf(cache, cache_size, "%s", line);
                        if (l < 0) {
                                perror("Error writing to cache");
                                rv = 0;
@@ -3570,8 +3584,17 @@ static int proc_stat_read(char *buf, size_t size, off_t offset,
                cache_size -= l;
                total_len += l;
 
-               if (sscanf(line, "%*s %lu %lu %lu %lu %lu %lu %lu %lu %lu", &user, &nice, &system, &idle, &iowait, &irq,
-                       &softirq, &steal, &guest) != 9)
+               if (sscanf(line, "%*s %lu %lu %lu %lu %lu %lu %lu %lu %lu %lu",
+                          &user,
+                          &nice,
+                          &system,
+                          &idle,
+                          &iowait,
+                          &irq,
+                          &softirq,
+                          &steal,
+                          &guest,
+                          &guest_nice) != 10)
                        continue;
                user_sum += user;
                nice_sum += nice;
@@ -3582,16 +3605,26 @@ static int proc_stat_read(char *buf, size_t size, off_t offset,
                softirq_sum += softirq;
                steal_sum += steal;
                guest_sum += guest;
+               guest_nice_sum += guest_nice;
        }
 
        cache = d->buf;
 
-       int cpuall_len = snprintf(cpuall, CPUALL_MAX_SIZE, "%s %lu %lu %lu %lu %lu %lu %lu %lu %lu\n",
-               "cpu ", user_sum, nice_sum, system_sum, idle_sum, iowait_sum, irq_sum, softirq_sum, steal_sum, guest_sum);
-       if (cpuall_len > 0 && cpuall_len < CPUALL_MAX_SIZE){
+       int cpuall_len = snprintf(cpuall, CPUALL_MAX_SIZE, "cpu  %lu %lu %lu %lu %lu %lu %lu %lu %lu %lu\n",
+                       user_sum,
+                       nice_sum,
+                       system_sum,
+                       idle_sum,
+                       iowait_sum,
+                       irq_sum,
+                       softirq_sum,
+                       steal_sum,
+                       guest_sum,
+                       guest_nice_sum);
+       if (cpuall_len > 0 && cpuall_len < CPUALL_MAX_SIZE) {
                memcpy(cache, cpuall, cpuall_len);
                cache += cpuall_len;
-       } else{
+       } else {
                /* shouldn't happen */
                lxcfs_error("proc_stat_read copy cpuall failed, cpuall_len=%d.", cpuall_len);
                cpuall_len = 0;
@@ -3601,7 +3634,8 @@ static int proc_stat_read(char *buf, size_t size, off_t offset,
        total_len += cpuall_len;
        d->cached = 1;
        d->size = total_len;
-       if (total_len > size ) total_len = size;
+       if (total_len > size)
+               total_len = size;
 
        memcpy(buf, d->buf, total_len);
        rv = total_len;
@@ -3617,23 +3651,12 @@ err:
 
 static long int getreaperage(pid_t pid)
 {
-       char fnam[100];
-       struct stat sb;
-       int ret;
-       pid_t qpid;
+       long int ctime;
 
-       qpid = lookup_initpid_in_store(pid);
-       if (qpid <= 0)
-               return 0;
-
-       ret = snprintf(fnam, 100, "/proc/%d", qpid);
-       if (ret < 0 || ret >= 100)
-               return 0;
-
-       if (lstat(fnam, &sb) < 0)
-               return 0;
-
-       return time(NULL) - sb.st_ctime;
+       ctime = getreaperctime(pid);
+       if (ctime)
+               return time(NULL) - ctime;
+       return ctime;
 }
 
 static unsigned long get_reaper_busy(pid_t task)
@@ -3859,8 +3882,7 @@ static int proc_swaps_read(char *buf, size_t size, off_t offset,
        struct fuse_context *fc = fuse_get_context();
        struct file_info *d = (struct file_info *)fi->fh;
        char *cg = NULL;
-       char *memswlimit_str = NULL, *memlimit_str = NULL, *memusage_str = NULL, *memswusage_str = NULL,
-             *memswlimit_default_str = NULL, *memswusage_default_str = NULL;
+       char *memswlimit_str = NULL, *memlimit_str = NULL, *memusage_str = NULL, *memswusage_str = NULL;
        unsigned long memswlimit = 0, memlimit = 0, memusage = 0, memswusage = 0, swap_total = 0, swap_free = 0;
        ssize_t total_len = 0, rv = 0;
        ssize_t l = 0;
@@ -3885,32 +3907,19 @@ static int proc_swaps_read(char *buf, size_t size, off_t offset,
                return read_file("/proc/swaps", buf, size, d);
        prune_init_slice(cg);
 
-       if (!cgfs_get_value("memory", cg, "memory.limit_in_bytes", &memlimit_str))
-               goto err;
+       memlimit = get_min_memlimit(cg, "memory.limit_in_bytes");
 
        if (!cgfs_get_value("memory", cg, "memory.usage_in_bytes", &memusage_str))
                goto err;
 
-       memlimit = strtoul(memlimit_str, NULL, 10);
        memusage = strtoul(memusage_str, NULL, 10);
 
        if (cgfs_get_value("memory", cg, "memory.memsw.usage_in_bytes", &memswusage_str) &&
            cgfs_get_value("memory", cg, "memory.memsw.limit_in_bytes", &memswlimit_str)) {
 
-                /* If swap accounting is turned on, then default value is assumed to be that of cgroup / */
-                if (!cgfs_get_value("memory", "/", "memory.memsw.limit_in_bytes", &memswlimit_default_str))
-                    goto err;
-                if (!cgfs_get_value("memory", "/", "memory.memsw.usage_in_bytes", &memswusage_default_str))
-                    goto err;
-
-               memswlimit = strtoul(memswlimit_str, NULL, 10);
+               memswlimit = get_min_memlimit(cg, "memory.memsw.limit_in_bytes");
                memswusage = strtoul(memswusage_str, NULL, 10);
 
-                if (!strcmp(memswlimit_str, memswlimit_default_str))
-                    memswlimit = 0;
-                if (!strcmp(memswusage_str, memswusage_default_str))
-                    memswusage = 0;
-
                swap_total = (memswlimit - memlimit) / 1024;
                swap_free = (memswusage - memusage) / 1024;
        }
@@ -3964,8 +3973,6 @@ err:
        free(memlimit_str);
        free(memusage_str);
        free(memswusage_str);
-       free(memswusage_default_str);
-       free(memswlimit_default_str);
        return rv;
 }
 
@@ -4480,7 +4487,7 @@ static void __attribute__((constructor)) collect_and_mount_subsystems(void)
                goto out;
        }
 
-       fd_hierarchies = malloc(sizeof(int *) * num_hierarchies);
+       fd_hierarchies = malloc(sizeof(int) * num_hierarchies);
        if (!fd_hierarchies) {
                lxcfs_error("%s\n", strerror(errno));
                goto out;