]> git.proxmox.com Git - mirror_qemu.git/commit - backends/rng-egd.c
backends: Improve error messages when property can no longer be set
authorMarkus Armbruster <armbru@redhat.com>
Wed, 12 Oct 2022 15:37:59 +0000 (17:37 +0200)
committerMarkus Armbruster <armbru@redhat.com>
Thu, 27 Oct 2022 05:56:56 +0000 (07:56 +0200)
commitff924448849f4fca48df15ecad67dc93854392e5
tree73797ff424969e0b3d5a42d57dbdd40d64aaba9f
parent3f7febc93785bf0e622072b01f846d2acbcd9c0b
backends: Improve error messages when property can no longer be set

When you try to set virtio-rng property "filename" after the backend
has been completed with user_creatable_complete(), the error message
blames "insufficient permission":

    $ qemu-system-x86_64 -S -display none -nodefaults -monitor stdio -object rng-random,id=rng0 -device virtio-rng,id=vrng0,rng=rng0
    QEMU 7.1.50 monitor - type 'help' for more information
    (qemu) qom-set /objects/rng0 filename /dev/random
    Error: Insufficient permission to perform this operation

This implies it could work with "sufficient permission".  It can't.
Change the error message to:

    Error: Property 'filename' can no longer be set

Same for cryptodev-vhost-user property "chardev", rng-egd property
"chardev", and vhost-user-backend property "chardev".

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20221012153801.2604340-3-armbru@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
[Commit message tidied up]
backends/cryptodev-vhost-user.c
backends/rng-egd.c
backends/rng-random.c
backends/vhost-user.c