]> git.proxmox.com Git - mirror_qemu.git/commit - block.c
blockdev: Refuse to open encrypted image unless paused
authorMarkus Armbruster <armbru@redhat.com>
Fri, 14 Mar 2014 08:22:48 +0000 (09:22 +0100)
committerStefan Hajnoczi <stefanha@redhat.com>
Fri, 14 Mar 2014 15:24:42 +0000 (16:24 +0100)
commitc3adb58fe0b2db4942f5b2f5d19bc51a29b93a89
tree7875a74aa811339f9905452b923540e71c911fdc
parent5d92c74f8a1728a202ba9457872ab0f27ff15e81
blockdev: Refuse to open encrypted image unless paused

Opening an encrypted image takes an additional step: setting the key.
Between open and the key set, the image must not be used.

We have some protection against accidental use in place: you can't
unpause a guest while we're missing keys.  You can, however, hot-plug
block devices lacking keys into a running guest just fine, or insert
media lacking keys.  In the latter case, notifying the guest of the
insert is delayed until the key is set, which may suffice to protect
at least some guests in common usage.

This patch makes the protection apply in more cases, in a rather
heavy-handed way: it doesn't let you open encrypted images unless
we're in a paused state.

It doesn't extend the protection to users other than the guest (block
jobs?).  Use of runstate_check() from block.c is disgusting.  Best I
can do right now.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
block.c
stubs/Makefile.objs
stubs/runstate-check.c [new file with mode: 0644]
tests/qemu-iotests/087
tests/qemu-iotests/087.out