]> git.proxmox.com Git - mirror_qemu.git/commit - block.c
util: Emancipate id_wellformed() from QemuOpts
authorMarkus Armbruster <armbru@redhat.com>
Tue, 30 Sep 2014 11:59:30 +0000 (13:59 +0200)
committerStefan Hajnoczi <stefanha@redhat.com>
Fri, 3 Oct 2014 09:30:33 +0000 (10:30 +0100)
commitf5bebbbb28dc7a149a891f0f1e112fb50bb72664
tree8bf30a59e4ce61326a92cefc7d03036104bdb170
parentd93162e13c1f4a5b2a4de6b1997f32e3fca19e67
util: Emancipate id_wellformed() from QemuOpts

IDs have long spread beyond QemuOpts: not everything with an ID
necessarily goes through QemuOpts.  Commit 9aebf3b is about such a
case: block layer names are meant to be well-formed IDs, but some of
them don't go through QemuOpts, and thus weren't checked.  The commit
fixed that the straightforward way: rename the internal QemuOpts
helper id_wellformed() to qemu_opts_id_wellformed() and give it
external linkage.

Instead of using it directly in block.c, the commit adds wrapper
bdrv_is_valid_name(), probably to hide the connection to QemuOpts.

Go one logical step further: emancipate IDs from QemuOpts.  Rename the
function back to id_wellformed(), and put it in another file.  While
there, clean up its value to bool.  Peel off the bdrv_is_valid_name()
wrapper.

[Replaced stray return 0 with return false to match bool returns used
elsewhere in id_wellformed().
--Stefan]

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
block.c
include/qemu-common.h
include/qemu/option.h
util/Makefile.objs
util/id.c [new file with mode: 0644]
util/qemu-option.c