]> git.proxmox.com Git - mirror_qemu.git/commit - block/gluster.c
block: Merge .bdrv_co_writev{,_flags} in drivers
authorEric Blake <eblake@redhat.com>
Tue, 24 Apr 2018 22:01:57 +0000 (17:01 -0500)
committerKevin Wolf <kwolf@redhat.com>
Tue, 15 May 2018 14:11:41 +0000 (16:11 +0200)
commite18a58b4e3aa355a9b6eef1f39a980a4f18f1294
tree146a95a5e75593be186f02dceef82ca8c86bee28
parentedfab6a08b0dc240ac3a665adf4dc40db9b9ec7f
block: Merge .bdrv_co_writev{,_flags} in drivers

We have too many driver callback interfaces; simplify the mess
somewhat by merging the flags parameter of .bdrv_co_writev_flags()
into .bdrv_co_writev().  Note that as long as a driver doesn't set
.supported_write_flags, the flags argument will be 0 and behavior is
identical.  Also note that the public function bdrv_co_writev() still
lacks a flags argument; so the driver signature is thus intentionally
slightly different.  But that's not the end of the world, nor the first
time that the driver interface differs slightly from the public
interface.

Ideally, we should be rewriting all of these drivers to use modern
byte-based interfaces.  But that's a more invasive patch to write
and audit, compared to the simplification done here.

Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block/gluster.c
block/io.c
block/iscsi.c
block/parallels.c
block/qcow.c
block/qed.c
block/replication.c
block/sheepdog.c
block/ssh.c
block/vhdx.c
include/block/block_int.h