]> git.proxmox.com Git - mirror_qemu.git/commit - block/vmdk.c
block/vmdk: Fix the endian problem of buf_len and lba
authorQingFeng Hao <haoqf@linux.vnet.ibm.com>
Fri, 16 Dec 2016 05:20:40 +0000 (06:20 +0100)
committerMax Reitz <mreitz@redhat.com>
Sat, 11 Feb 2017 23:47:42 +0000 (00:47 +0100)
commit4545d4f4af8b29ba3b38dfb74d6f45342e15a62d
tree4428bc6f4d530ad3fb51b6976f7d36b836f4b6a3
parent36bd4228126139a382a4fdbc49c96798a9894626
block/vmdk: Fix the endian problem of buf_len and lba

The problem was triggered by qemu-iotests case 055. It failed when it
was comparing the compressed vmdk image with original test.img.

The cause is that buf_len in vmdk_write_extent wasn't converted to
little-endian before it was stored to disk. But later vmdk_read_extent
read it and converted it from little-endian to cpu endian.
If the cpu is big-endian like s390, the problem will happen and
the data length read by vmdk_read_extent will become invalid!
The fix is to add the conversion in vmdk_write_extent, meanwhile,
repair the endianness problem of lba field which shall also be converted
to little-endian before storing to disk.

Cc: qemu-stable@nongnu.org
Signed-off-by: QingFeng Hao <haoqf@linux.vnet.ibm.com>
Signed-off-by: Jing Liu <liujbjl@linux.vnet.ibm.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Message-id: 20161216052040.53067-2-haoqf@linux.vnet.ibm.com
Signed-off-by: Max Reitz <mreitz@redhat.com>
block/vmdk.c