]> git.proxmox.com Git - mirror_qemu.git/commit - blockdev.c
block: Remove BDRV_O_CACHE_WB
authorKevin Wolf <kwolf@redhat.com>
Fri, 18 Mar 2016 16:46:45 +0000 (17:46 +0100)
committerKevin Wolf <kwolf@redhat.com>
Wed, 30 Mar 2016 10:16:03 +0000 (12:16 +0200)
commit61de4c680846167e01d7ba42bf787f8d1d80bf5e
treeec4a6353a6f747b6201e5411ad77382ad39f2437
parent53e8ae010071637b4317402e2ece9e4dbb329c50
block: Remove BDRV_O_CACHE_WB

The previous patches have successively made blk->enable_write_cache the
true source for the information whether a writethrough mode must be
implemented. The corresponding BDRV_O_CACHE_WB is only useless baggage
we're carrying around, so now's the time to remove it.

At the same time, we remove the 'cache.writeback' option parsing on the
BDS level as the only effect was setting the BDRV_O_CACHE_WB flag.

This change requires test cases that explicitly enabled the option to
drop it. Other than that and the change of the error message when
writethrough is enabled on the BDS level (from "Can't set writethrough
mode" to "doesn't support the option"), there should be no change in
behaviour.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
block.c
block/block-backend.c
block/vvfat.c
blockdev.c
include/block/block.h
qemu-img.c
qemu-io-cmds.c
tests/qemu-iotests/051
tests/qemu-iotests/051.pc.out
tests/qemu-iotests/142
tests/qemu-iotests/142.out