]> git.proxmox.com Git - mirror_qemu.git/commit - cpu-exec.c
tcg: drop global lock during TCG code execution
authorJan Kiszka <jan.kiszka@siemens.com>
Thu, 23 Feb 2017 18:29:11 +0000 (18:29 +0000)
committerAlex Bennée <alex.bennee@linaro.org>
Fri, 24 Feb 2017 10:32:45 +0000 (10:32 +0000)
commit8d04fb55dec381bc5105cb47f29d918e579e8cbd
tree279eb632e33d57c869bae0b70c6261af5d0e854a
parent791158d93b27f22a17c2ada06621831d54f09a2c
tcg: drop global lock during TCG code execution

This finally allows TCG to benefit from the iothread introduction: Drop
the global mutex while running pure TCG CPU code. Reacquire the lock
when entering MMIO or PIO emulation, or when leaving the TCG loop.

We have to revert a few optimization for the current TCG threading
model, namely kicking the TCG thread in qemu_mutex_lock_iothread and not
kicking it in qemu_cpu_kick. We also need to disable RAM block
reordering until we have a more efficient locking mechanism at hand.

Still, a Linux x86 UP guest and my Musicpal ARM model boot fine here.
These numbers demonstrate where we gain something:

20338 jan       20   0  331m  75m 6904 R   99  0.9   0:50.95 qemu-system-arm
20337 jan       20   0  331m  75m 6904 S   20  0.9   0:26.50 qemu-system-arm

The guest CPU was fully loaded, but the iothread could still run mostly
independent on a second core. Without the patch we don't get beyond

32206 jan       20   0  330m  73m 7036 R   82  0.9   1:06.00 qemu-system-arm
32204 jan       20   0  330m  73m 7036 S   21  0.9   0:17.03 qemu-system-arm

We don't benefit significantly, though, when the guest is not fully
loading a host CPU.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Message-Id: <1439220437-23957-10-git-send-email-fred.konrad@greensocs.com>
[FK: Rebase, fix qemu_devices_reset deadlock, rm address_space_* mutex]
Signed-off-by: KONRAD Frederic <fred.konrad@greensocs.com>
[EGC: fixed iothread lock for cpu-exec IRQ handling]
Signed-off-by: Emilio G. Cota <cota@braap.org>
[AJB: -smp single-threaded fix, clean commit msg, BQL fixes]
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <rth@twiddle.net>
Reviewed-by: Pranith Kumar <bobby.prani@gmail.com>
[PM: target-arm changes]
Acked-by: Peter Maydell <peter.maydell@linaro.org>
18 files changed:
cpu-exec.c
cpus.c
cputlb.c
exec.c
hw/core/irq.c
hw/i386/kvmvapic.c
hw/intc/arm_gicv3_cpuif.c
hw/ppc/ppc.c
hw/ppc/spapr.c
include/qom/cpu.h
memory.c
qom/cpu.c
target/arm/helper.c
target/arm/op_helper.c
target/i386/smm_helper.c
target/s390x/misc_helper.c
translate-all.c
translate-common.c