]> git.proxmox.com Git - mirror_qemu.git/commit - monitor.c
qmp qemu-ga: Fix qemu-ga not to accept "control"
authorMarkus Armbruster <armbru@redhat.com>
Tue, 3 Jul 2018 08:53:37 +0000 (10:53 +0200)
committerMarkus Armbruster <armbru@redhat.com>
Tue, 3 Jul 2018 21:18:56 +0000 (23:18 +0200)
commit674ed7228f03150d15703961ea2a59cd744f3beb
treeed42dce070bd3934e6b9358d1391e29a0be3ff03
parentd4d7ed731ce47d10ea2a17d663cec42fc0c7d925
qmp qemu-ga: Fix qemu-ga not to accept "control"

Commit cf869d53172 "qmp: support out-of-band (oob) execution"
accidentally made qemu-ga accept and ignore "control".  Fix that.

Out-of-band execution in a monitor that doesn't support it now fails
with

    {"error": {"class": "GenericError", "desc": "QMP input member 'control' is unexpected"}}

instead of

    {"error": {"class": "GenericError", "desc": "Please enable out-of-band first for the session during capabilities negotiation"}}

The old description is suboptimal when out-of-band cannot not be
enabled, or the command doesn't support out-of-band execution.

The new description is a bit unspecific, but it'll do.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20180703085358.13941-12-armbru@redhat.com>
include/qapi/qmp/dispatch.h
monitor.c
qapi/qmp-dispatch.c
qga/main.c
tests/test-qga.c
tests/test-qmp-cmds.c