]> git.proxmox.com Git - mirror_qemu.git/commit - monitor.c
monitor: unify global init
authorPeter Xu <peterx@redhat.com>
Fri, 9 Mar 2018 08:59:50 +0000 (16:59 +0800)
committerEric Blake <eblake@redhat.com>
Mon, 19 Mar 2018 19:58:36 +0000 (14:58 -0500)
commit6adf08dd42929542426b055a4b66a5bc0b8e20ba
treeee702a801d4f4ac7066994fe8d8f33354dda32c7
parent227a07552f3aff3cefe7eb9f8993c04a420ed962
monitor: unify global init

There are many places where the monitor initializes its globals:

- monitor_init_qmp_commands() at the very beginning
- single function to init monitor_lock
- in the first entry of monitor_init() using "is_first_init"

Unify them a bit.

monitor_lock is not used before monitor_init() (as confirmed by code
analysis and gdb watchpoints); so we are safe delaying what was a
constructor-time initialization of the mutex into the later first call
to monitor_init().

Reviewed-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
Message-Id: <20180309090006.10018-8-peterx@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
include/monitor/monitor.h
monitor.c
vl.c