]> git.proxmox.com Git - mirror_qemu.git/commit - monitor.c
cutils: Fix qemu_strtosz() & friends to reject non-finite sizes
authorDavid Hildenbrand <david@redhat.com>
Wed, 21 Nov 2018 16:44:14 +0000 (17:44 +0100)
committerMarkus Armbruster <armbru@redhat.com>
Thu, 13 Dec 2018 18:10:06 +0000 (19:10 +0100)
commitaf02f4c5179675ad4e26b17ba26694a8fcde17fa
tree7b316a4e89c962284f479f604f4b2515b4cc4f97
parentca28f5481607e5c59481e70e429f5dd23662cb69
cutils: Fix qemu_strtosz() & friends to reject non-finite sizes

qemu_strtosz() & friends reject NaNs, but happily accept infinities.
They shouldn't. Fix that.

The fix makes use of qemu_strtod_finite(). To avoid ugly casts,
change the @end parameter of qemu_strtosz() & friends from char **
to const char **.

Also, add two test cases, testing that "inf" and "NaN" are properly
rejected. While at it, also fixup the function documentation.

Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20181121164421.20780-3-david@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
include/qemu/cutils.h
monitor.c
tests/test-cutils.c
util/cutils.c