]> git.proxmox.com Git - mirror_qemu.git/commit - os-win32.c
win32: fix memory leak
authorZhi Hui Li <zhihuili@linux.vnet.ibm.com>
Thu, 24 Nov 2011 08:27:52 +0000 (16:27 +0800)
committerStefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Tue, 6 Dec 2011 09:56:41 +0000 (09:56 +0000)
commit91a9ecefb6d7f066c6eecc09f7231ce7969d1817
treeb9b6aa6d2ec6f6cb539fa2caebc7da0bf07a4b00
parentc7ee8f683d93c7ea346a5eb86495da672ce7e7da
win32: fix memory leak

string is allocated by g_malloc, will not be used after putenv, should be
free before return.

Paolo Bonzini <pbonzini@redhat.com> confirmed this is safe under Wine:

"1) the underlying Win32 APIs require separate arguments for the
variable and value; 2) even though in the end Wine stores the
environment as name=value
(http://source.winehq.org/source/dlls/ntdll/env.c), it does so in a
single consecutive block of memory, not as a char* array like POSIX
does.  While (2) might apply only to Wine, (1) surely applies to Windows
as well."

Tested-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Li Zhi Hui <zhihuili@linux.vnet.ibm.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
os-win32.c