]> git.proxmox.com Git - mirror_qemu.git/commit - qemu-img.c
block: Switch discard length bounds to byte-based
authorEric Blake <eblake@redhat.com>
Thu, 23 Jun 2016 22:37:21 +0000 (16:37 -0600)
committerKevin Wolf <kwolf@redhat.com>
Tue, 5 Jul 2016 14:46:25 +0000 (16:46 +0200)
commitb9f7855a50a7cbf04454fa84e9d1f333151f2259
tree15fa9cfcfab14eccc0eaa76dc3ec56ee22c27a06
parent29cc6a6834add5cddbc391d07c1b3ace2ad9b8eb
block: Switch discard length bounds to byte-based

Sector-based limits are awkward to think about; in our on-going
quest to move to byte-based interfaces, convert max_discard and
discard_alignment.  Rename them, using 'pdiscard' as an aid to
track which remaining discard interfaces need conversion, and so
that the compiler will help us catch the change in semantics
across any rebased code.  The BlockLimits type is now completely
byte-based; and in iscsi.c, sector_limits_lun2qemu() is no
longer needed.

pdiscard_alignment is made unsigned (we use power-of-2 alignments
as bitmasks, where unsigned is easier to think about) while
leaving max_pdiscard signed (since we still have an 'int'
interface); this is comparable to what commit cf081fc did for
write zeroes limits.  We may later want to make everything an
unsigned 64-bit limit - but that requires a bigger code audit.

Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block/io.c
block/iscsi.c
block/nbd.c
include/block/block_int.h
qemu-img.c