]> git.proxmox.com Git - mirror_qemu.git/commit - qemu-img.c
qemu-img: always probe the input image for allocated sectors
authorPaolo Bonzini <pbonzini@redhat.com>
Wed, 4 Sep 2013 17:00:26 +0000 (19:00 +0200)
committerStefan Hajnoczi <stefanha@redhat.com>
Fri, 6 Sep 2013 13:25:09 +0000 (15:25 +0200)
commite4a86f88cc6b214c37b4abe9160e41f0338ce4cd
treea1710560ebe26f29a6b2b537d08a40e7efc00751
parentd663640c04f2aab810915c556390211d75457704
qemu-img: always probe the input image for allocated sectors

qemu-img convert can assume "that sectors which are unallocated in the
input image are present in both the output's and input's base images".

However it is only doing this if the output image returns true for
bdrv_has_zero_init().  Testing bdrv_has_zero_init() does not make much
sense if the output image is copy-on-write, because a copy-on-write
image is never initialized to zero (it is initialized to the content
of the backing file).

There is nothing here that makes has_zero_init images special.  The
input and output must be equal for the operation to make sense, and
that's it.

Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
qemu-img.c