]> git.proxmox.com Git - mirror_qemu.git/commit - target/i386/cpu.c
target-i386: Call cpu_exec_init() on realize
authorEduardo Habkost <ehabkost@redhat.com>
Fri, 13 Feb 2015 01:04:50 +0000 (23:04 -0200)
committerEduardo Habkost <ehabkost@redhat.com>
Mon, 23 May 2016 22:47:37 +0000 (19:47 -0300)
commit42ecabaae16c0054dde6d8b0fdf90a8c7cce270d
treed33885a9858825b59341944e70cbc025e40fd47e
parent57f2453ab48a771b30aeced01b329ee85853bb7b
target-i386: Call cpu_exec_init() on realize

QOM instance_init functions are not supposed to have any side-effects,
as new objects may be created at any moment for querying property
information (see qmp_device_list_properties()).

Calling cpu_exec_init() also affects QEMU's ability to handle errors
during CPU creation, as some actions done by cpu_exec_init() can't be
reverted.

Move cpu_exec_init() call to realize so a simple object_new() won't
trigger it, and so that it is called after some basic validation of CPU
parameters.

Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
target-i386/cpu.c