]> git.proxmox.com Git - mirror_qemu.git/commit - target/i386/cpu.c
cpu: Use CPUClass->parse_features() as convertor to global properties
authorIgor Mammedov <imammedo@redhat.com>
Thu, 9 Jun 2016 17:11:01 +0000 (19:11 +0200)
committerEduardo Habkost <ehabkost@redhat.com>
Thu, 7 Jul 2016 18:25:01 +0000 (15:25 -0300)
commit62a48a2a5798425997152dea3fc48708f9116c04
treed07e143d87334112feb80a2422ccb5e7afdb65c7
parentcf2887c9738451eb989c6c102af070dee2dc172a
cpu: Use CPUClass->parse_features() as convertor to global properties

Currently CPUClass->parse_features() is used to parse -cpu
features string and set properties on created CPU instances.

But considering that features specified by -cpu apply to every
created CPU instance, it doesn't make sense to parse the same
features string for every CPU created. It also makes every target
that cares about parsing features string explicitly call
CPUClass->parse_features() parser, which gets in a way if we
consider using generic device_add for CPU hotplug as device_add
has not a clue about CPU specific hooks.

Turns out we can use global properties mechanism to set
properties on every created CPU instance for a given type. That
way it's possible to convert CPU features into a set of global
properties for CPU type specified by -cpu cpu_model and common
Device.device_post_init() will apply them to CPU of given type
automatically regardless whether it's manually created CPU or CPU
created with help of device_add.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
hw/arm/virt.c
include/qom/cpu.h
qom/cpu.c
target-i386/cpu.c