]> git.proxmox.com Git - mirror_qemu.git/commit - target/i386/cpu.c
target-i386: Remove unused local_err variable
authorEduardo Habkost <ehabkost@redhat.com>
Fri, 25 Nov 2016 15:21:53 +0000 (13:21 -0200)
committerEduardo Habkost <ehabkost@redhat.com>
Fri, 25 Nov 2016 17:12:23 +0000 (15:12 -0200)
commit685479bd5dc6f54f6230c9d05d7a3fb5cab867bf
tree25e8a5b0dd4e3e8f72a4a29b8db8d33f435a9126
parent00227fefd2059464cd2f59aed29944874c630e2f
target-i386: Remove unused local_err variable

local_err can never be set to non-NULL. Remove the variable.

Detected by Coverity:

    *** CID 1365201:  Possible Control flow issues  (DEADCODE)
    /target-i386/cpu.c: 2050 in x86_cpu_parse_featurestr()
    2044             prop->value = g_strdup(val);
    2045             prop->errp = &error_fatal;
    2046             qdev_prop_register_global(prop);
    2047         }
    2048
    2049         if (local_err) {
    >>>     CID 1365201:  Possible Control flow issues  (DEADCODE)
    >>>     Execution cannot reach this statement: "error_propagate(errp, local...".
    2050             error_propagate(errp, local_err);
    2051         }
    2052     }
    2053
    2054     static void x86_cpu_load_features(X86CPU *cpu, Error **errp);
    2055     static int x86_cpu_filter_features(X86CPU *cpu);

Reported-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <1480087313-15102-1-git-send-email-ehabkost@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
target-i386/cpu.c