]> git.proxmox.com Git - mirror_qemu.git/commit - tests/migration-test.c
migration-test: Clean up string interpolation into QMP, part 2
authorMarkus Armbruster <armbru@redhat.com>
Mon, 6 Aug 2018 06:53:40 +0000 (08:53 +0200)
committerMarkus Armbruster <armbru@redhat.com>
Thu, 16 Aug 2018 06:42:06 +0000 (08:42 +0200)
commitb5bbd3f315d686bd511f5be72e4aab3b2bd52de8
treef9f1cfacf7f0197b6c9575efc3350d1c4479fdfe
parentb7281c6989c09a98670ea11c588b17737c846154
migration-test: Clean up string interpolation into QMP, part 2

Leaving interpolation into JSON to qmp() is more robust than building
QMP input manually, as explained in the recent commit "tests: Clean up
string interpolation into QMP input (simple cases)".

migrate() interpolates members into a JSON object.  Change it to take
its extra QMP arguments as arguments for qdict_from_jsonf_nofail()
instead of a string containing JSON members.

Bonus: gets rid of a non-literal format string.  A step towards
compile-time format string checking without triggering
-Wformat-nonliteral.

Cc: Juan Quintela <quintela@redhat.com>
Cc: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20180806065344.7103-20-armbru@redhat.com>
tests/migration-test.c