]> git.proxmox.com Git - mirror_qemu.git/commit - ui/cursor.c
ui/cursor: make width/height unsigned 16-bit integer
authorMauro Matteo Cascella <mcascell@redhat.com>
Tue, 23 May 2023 16:30:23 +0000 (18:30 +0200)
committerMarc-André Lureau <marcandre.lureau@redhat.com>
Sun, 28 May 2023 09:08:25 +0000 (13:08 +0400)
commit4c93ce54e7114aae33100d2ee4f2b36e451a1d06
tree9b07ff722c0331548aefff62fabd76ad389d3870
parent1dfea3f212e43bfd59d1e1f40b9776db440b211f
ui/cursor: make width/height unsigned 16-bit integer

Although not actually exploitable at the moment, a negative width/height
could make datasize wrap around and potentially lead to buffer overflow.
Since there is no reason a negative width/height is ever appropriate,
modify QEMUCursor struct and cursor_alloc prototype to accept uint16_t.
This protects us against accidentally introducing future bugs.

Signed-off-by: Mauro Matteo Cascella <mcascell@redhat.com>
Reported-by: Jacek Halon <jacek.halon@gmail.com>
Reported-by: Yair Mizrahi <yairh33@gmail.com>
Reported-by: Elsayed El-Refa'ei <e.elrefaei99@gmail.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20230523163023.608121-1-mcascell@redhat.com>
include/ui/console.h
ui/cursor.c