]> git.proxmox.com Git - mirror_qemu.git/commit - util/oslib-win32.c
hostmem-file: reject invalid pmem file sizes
authorStefan Hajnoczi <stefanha@redhat.com>
Thu, 14 Feb 2019 03:10:04 +0000 (11:10 +0800)
committerEduardo Habkost <ehabkost@redhat.com>
Mon, 11 Mar 2019 13:44:19 +0000 (10:44 -0300)
commit314aec4a6e06844937f1677f6cba21981005f389
tree9321a3ea8b1083ef391d6ca5123f8b73eada42a5
parent336cfef495f0cd5b1606251c52628d0372e9a809
hostmem-file: reject invalid pmem file sizes

Guests started with NVDIMMs larger than the underlying host file produce
confusing errors inside the guest.  This happens because the guest
accesses pages beyond the end of the file.

Check the pmem file size on startup and print a clear error message if
the size is invalid.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1669053
Cc: Wei Yang <richardw.yang@linux.intel.com>
Cc: Zhang Yi <yi.z.zhang@linux.intel.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20190214031004.32522-3-stefanha@redhat.com>
Reviewed-by: Wei Yang <richardw.yang@linux.intel.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Pankaj Gupta <pagupta@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
backends/hostmem-file.c
include/qemu/osdep.h
util/oslib-posix.c
util/oslib-win32.c