]> git.proxmox.com Git - mirror_qemu.git/commit - vl.c
vl: Add another sanity check to smp_parse() function
authorThomas Huth <thuth@redhat.com>
Wed, 22 Jul 2015 13:59:50 +0000 (15:59 +0200)
committerEduardo Habkost <ehabkost@redhat.com>
Fri, 2 Oct 2015 19:22:01 +0000 (16:22 -0300)
commita32ef3bfc12c8d0588f43f74dcc5280885bbdb30
tree7c85f55a09e1e83d78110c2c7452b88cdd6ff8a7
parented256144cd6f0ca2ff59fc3fc8dca547506f433b
vl: Add another sanity check to smp_parse() function

The code in smp_parse already checks the topology information for
sockets * cores * threads < cpus and bails out with an error in
that case. However, it is still possible to supply a bad configuration
the other way round, e.g. with:

 qemu-system-xxx -smp 4,sockets=1,cores=4,threads=2

QEMU then still starts the guest, with topology configuration that
is rather incomprehensible and likely not what the user wanted.
So let's add another check to refuse such wrong configurations.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Acked-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
vl.c