]> git.proxmox.com Git - mirror_qemu.git/commit
nbd/server: Don't fail NBD_OPT_INFO for byte-aligned sources
authorEric Blake <eblake@redhat.com>
Wed, 3 Apr 2019 03:05:22 +0000 (22:05 -0500)
committerEric Blake <eblake@redhat.com>
Mon, 8 Apr 2019 18:49:25 +0000 (13:49 -0500)
commit099fbcd65c2064a4ba8251e749bf600055027759
treec8c01817bf1fd4b69c55c4734b574282085bf5b4
parent6e280648d21d8c0aa8a101b62d0732cd1e608743
nbd/server: Don't fail NBD_OPT_INFO for byte-aligned sources

In commit 0c1d50bd, I added a couple of TODO comments about whether we
consult bl.request_alignment when responding to NBD_OPT_INFO. At the
time, qemu as server was hard-coding an advertised alignment of 512 to
clients that promised to obey constraints, and there was no function
for getting at a device's preferred alignment. But in hindsight,
advertising 512 when the block device prefers 1 caused other
compliance problems, and commit b0245d64 changed one of the two TODO
comments to advertise a more accurate alignment. Time to fix the other
TODO.  Doesn't really impact qemu as client (our normal client doesn't
use NBD_OPT_INFO, and qemu-nbd --list promises to obey block sizes),
but it might prove useful to other clients.

Fixes: b0245d64
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20190403030526.12258-4-eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
nbd/server.c