]> git.proxmox.com Git - mirror_qemu.git/commit
tests/acpi: don't pack a structure
authorMichael S. Tsirkin <mst@redhat.com>
Thu, 30 Mar 2017 15:30:59 +0000 (18:30 +0300)
committerMichael S. Tsirkin <mst@redhat.com>
Thu, 30 Mar 2017 16:12:44 +0000 (19:12 +0300)
commit0d876080a394993a8dea494ebf2d806dc0983107
treeeb7c67ce8894aaec18232fdbc78664fb1436e246
parent375f74f473cfcb0c73a64088a6a5880829c155da
tests/acpi: don't pack a structure

There's no reason to pack structures where we don't care about size or
padding, this applies to AcpiStdTable in tests/acpi-utils.h.

OTOH bios-tables-test happens to be passing the address of a field in
this  struct to a function that expects a pointer to normally aligned
data which results in a SIGBUS on architectures like SPARC that have
strict alignment requirements.

Fixes: 9e8458c02 ("acpi unit-test: compare DSDT and SSDT tables against expected values")
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Tested-by: Peter Maydell <peter.maydell@linaro.org>
tests/acpi-utils.h